From owner-freebsd-current@FreeBSD.ORG Thu Dec 20 18:16:42 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D7EA4E29; Thu, 20 Dec 2012 18:16:42 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from smtprelay06.ispgateway.de (smtprelay06.ispgateway.de [80.67.31.103]) by mx1.freebsd.org (Postfix) with ESMTP id EEE0F8FC12; Thu, 20 Dec 2012 18:16:41 +0000 (UTC) Received: from [84.44.155.174] (helo=fabiankeil.de) by smtprelay06.ispgateway.de with esmtpsa (SSLv3:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1Tlkfb-0006pb-6K; Thu, 20 Dec 2012 19:16:35 +0100 Date: Thu, 20 Dec 2012 19:12:43 +0100 From: Fabian Keil To: Alexander Motin Subject: Re: [RFC/RFT] calloutng Message-ID: <20121220191243.7cd00b2a@fabiankeil.de> In-Reply-To: <50D3201F.4080605@FreeBSD.org> References: <50CCAB99.4040308@FreeBSD.org> <50CE5B54.3050905@FreeBSD.org> <50D03173.9080904@FreeBSD.org> <20121220115629.3379a261@fabiankeil.de> <50D2F923.2020303@FreeBSD.org> <20121220142600.22c4796a@fabiankeil.de> <50D3201F.4080605@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/uY3hCL0vVS9LVX6Lk4en9Ol"; protocol="application/pgp-signature" X-Df-Sender: Nzc1MDY3 Cc: FreeBSD Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2012 18:16:42 -0000 --Sig_/uY3hCL0vVS9LVX6Lk4en9Ol Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Alexander Motin wrote: > On 20.12.2012 15:26, Fabian Keil wrote: > > Alexander Motin wrote: > > > >> On 20.12.2012 12:56, Fabian Keil wrote: > >>> Alexander Motin wrote: > >>> > >>>> Experiments with dummynet shown ineffective support for very short > >>>> tick-based callouts. New version fixes that, allowing to get as many > >>>> tick-based callout events as hz value permits, while still be able to > >>>> aggregate events and generating minimum of interrupts. > >>>> > >>>> Also this version modifies system load average calculation to fix so= me > >>>> cases existing in HEAD and 9 branches, that could be fixed with new > >>>> direct callout functionality. > >>>> > >>>> http://people.freebsd.org/~mav/calloutng_12_17.patch > >>> > >>> With this patch (and the previous one, I didn't test the others) > >>> my mouse cursor is occasionally not reacting for short amounts of > >>> time (less than a second, but long enough to be noticeable). > >> Could you try to revert part of the patch, related to dev/atkbdc? I am > >> not strong in details of that hardware, but in comments there mention > >> that they are related. May be lost keyboard interrupts (which polling > >> rate was increased to 1 second) cause PS/2 mouse delays. > > > > I reverted the changes to sys/dev/atkbdc/* about an hour ago > > and so far it's looking good. I'll report back tomorrow after > > some more testing. > > Thank you for the report. If it will be fine. you can try to reapply=20 > that part of the patch, just changing line: > callout_reset_flags(&sc->callout, hz, atkbdtimeout, dev, C_PRELSET(0)); > to the: > callout_reset_flags(&sc->callout, hz/10, atkbdtimeout, dev, C_PRELSET(0)); >=20 > It should about to restore original polling interval, but still make it=20 > more flexible then original. With this change the mouse stops working completely after moving the cursor a couple of pixels, at which point dmesg shows: =20 kbdc: TEST_AUX_PORT status:0000 kbdc: RESET_AUX return code:00fa kbdc: RESET_AUX status:00aa kbdc: RESET_AUX ID:0000 Using the keyboard frequently causes duplicated characters. I'm aware of a problem in vanilla CURRENT where the mouse stops working with similar looking messages when the cursor is being moved "at the wrong moment", but this happens less than once a week and I haven't been able to track it down yet. It's possible that it's the same bug and your patch just triggers it more reliable (two times in a row). I haven't seen the duplicated-characters issue before, though. Just for kicks I also tried: callout_reset_flags(&sc->callout, hz/100, atkbdtimeout, dev, C_PRELSET(0)); but with this modification I can't even enter my login password and thus can't tell if the mouse would work. Fabian --Sig_/uY3hCL0vVS9LVX6Lk4en9Ol Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDTVR4ACgkQBYqIVf93VJ2KUQCfVKEBwTCsNVDl75Fcxym3gINS mmkAoJSqv6gnvw8lwco6+fdy07vSBE7c =+jbF -----END PGP SIGNATURE----- --Sig_/uY3hCL0vVS9LVX6Lk4en9Ol--