From owner-freebsd-current@FreeBSD.ORG Thu Mar 11 08:10:43 2010 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76D89106564A; Thu, 11 Mar 2010 08:10:43 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226]) by mx1.freebsd.org (Postfix) with ESMTP id 32CC48FC12; Thu, 11 Mar 2010 08:10:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by pele.citylink.co.nz (Postfix) with ESMTP id 14C2A7B6CE; Thu, 11 Mar 2010 21:10:42 +1300 (NZDT) X-Virus-Scanned: Debian amavisd-new at citylink.co.nz Received: from pele.citylink.co.nz ([127.0.0.1]) by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MBbErbHA7fs0; Thu, 11 Mar 2010 21:10:36 +1300 (NZDT) Received: from citylink.fud.org.nz (unknown [202.8.44.45]) by pele.citylink.co.nz (Postfix) with ESMTP; Thu, 11 Mar 2010 21:10:36 +1300 (NZDT) Received: by citylink.fud.org.nz (Postfix, from userid 1001) id C92EA11434; Thu, 11 Mar 2010 21:10:35 +1300 (NZDT) Date: Thu, 11 Mar 2010 21:10:35 +1300 From: Andrew Thompson To: Garrett Cooper Message-ID: <20100311081035.GA45454@citylink.fud.org.nz> References: <201003110629.o2B6TVta094218@freebsd-current.sentex.ca> <7d6fde3d1003102248g31b179f7u3bfe848408f91f2e@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d6fde3d1003102248g31b179f7u3bfe848408f91f2e@mail.gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: powerpc@freebsd.org, Weongyo Jeong , FreeBSD Tinderbox , current@freebsd.org Subject: Re: [head tinderbox] failure on powerpc/powerpc X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2010 08:10:43 -0000 On Wed, Mar 10, 2010 at 10:48:27PM -0800, Garrett Cooper wrote: > Weongyo, et all, > > On Wed, Mar 10, 2010 at 10:29 PM, FreeBSD Tinderbox > > /src/sys/modules/siba_bwn/../../dev/siba/siba_core.c:2035: error: request for member 'sd_bus' in something not a structure or union > > *** Error code 1 > > > > Stop in /src/sys/modules/siba_bwn. > > *** Error code 1 > > > > Stop in /src/sys/modules. > > *** Error code 1 > > > > Stop in /obj/powerpc/src/sys/LINT. > > *** Error code 1 > > > > Stop in /src. > > *** Error code 1 > > > > Stop in /src. > > TB --- 2010-03-11 06:29:31 - WARNING: /usr/bin/make returned exit code ?1 > > TB --- 2010-03-11 06:29:31 - ERROR: failed to build lint kernel > > TB --- 2010-03-11 06:29:31 - 3629.47 user 614.12 system 4685.83 real > > Could someone please try this patch to see whether or not it fixes > the void* deref issue? I don't think it's style(9) correct, but it > might resolve the issue. > Thanks, > -Garrett > > Index: siba_core.c > =================================================================== > --- siba_core.c (revision 204996) > +++ siba_core.c (working copy) > @@ -2032,9 +2032,9 @@ > siba_dma_translation(device_t dev) > { > > - KASSERT(device_get_ivars(dev)->sd_bus->siba_type == SIBA_TYPE_PCI, > - ("unsupported bustype %d\n", > - device_get_ivars(dev)->sd_bus->siba_type)); > + KASSERT(((struct siba_softc *) device_get_ivars(dev))->sd_bus->siba_type == > + SIBA_TYPE_PCI, ("unsupported bustype %d\n", > + ((struct siba_softc*) device_get_ivars(dev))->sd_bus->siba_type)); > It was all getting a bit unwieldy, I committed a more simple fix in r205003.