From owner-freebsd-ports@FreeBSD.ORG Fri Nov 9 13:13:26 2007 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACE5E16A419; Fri, 9 Nov 2007 13:13:26 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 5605A13C4B2; Fri, 9 Nov 2007 13:13:26 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 0D9EE2098; Fri, 9 Nov 2007 13:49:04 +0100 (CET) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: -0.1/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 75CD42092; Fri, 9 Nov 2007 13:49:03 +0100 (CET) Received: by ds4.des.no (Postfix, from userid 1001) id 4EE05844CB; Fri, 9 Nov 2007 13:49:03 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Luigi Rizzo References: <20071109040224.A44924@xorpc.icir.org> Date: Fri, 09 Nov 2007 13:49:03 +0100 In-Reply-To: <20071109040224.A44924@xorpc.icir.org> (Luigi Rizzo's message of "Fri\, 9 Nov 2007 04\:02\:24 -0800") Message-ID: <86hcjvk2io.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Cc: ports@freebsd.org, portmgr@freebsd.org Subject: Re: autoconf problem (with fix) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2007 13:13:26 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Luigi Rizzo writes: > I think an easy fix is to replace, in the wrapper, sed and find with > /usr/bin/sed and /usr/bin/find so that we have no surprises here, not > just with openwrt but also with other packages which use autoconf on a > non-standard environment. Sounds fine, if portmgr (Cc:ed) approves. See attached patch. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=autoconf-wrapper.diff Index: Makefile =================================================================== RCS file: /home/pcvs/ports/devel/autoconf-wrapper/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- Makefile 25 Oct 2007 11:15:18 -0000 1.2 +++ Makefile 9 Nov 2007 12:46:05 -0000 @@ -6,7 +6,7 @@ # PORTNAME?= autoconf-wrapper -PORTVERSION= 20071025 +PORTVERSION= 20071109 CATEGORIES= devel MASTER_SITES= # none DISTFILES= # none Index: files/autotools-wrapper.sh =================================================================== RCS file: /home/pcvs/ports/devel/autoconf-wrapper/files/autotools-wrapper.sh,v retrieving revision 1.2 diff -u -r1.2 autotools-wrapper.sh --- files/autotools-wrapper.sh 25 Oct 2007 11:15:19 -0000 1.2 +++ files/autotools-wrapper.sh 9 Nov 2007 12:45:55 -0000 @@ -63,10 +63,10 @@ # is present both as "toolABC" and as "tool-A.BC". We take no special # measures to handle this case. # -find ${bindir}/ -name "${tool}*[0-9]" | sed -E \ +/usr/bin/find ${bindir}/ -name "${tool}*[0-9]" | /usr/bin/sed -E \ -e "s@^.*/${tool}-([0-9])\\.([0-9]+)\$@\1 \2 -\1.\2@" \ -e "s@^.*/${tool}([0-9])([0-9]+)\$@\1 \2 \1\2@" | \ - sort -n -k1 | sort -n -s -k2 | { + /usr/bin/sort -n -k1 | /usr/bin/sort -n -s -k2 | { while read maj min suffix ; do selected_version="$maj$min" selected_suffix=$suffix --=-=-=--