From owner-freebsd-mips@FreeBSD.ORG Mon Apr 22 20:40:35 2013 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 7207A44C for ; Mon, 22 Apr 2013 20:40:35 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-la0-x229.google.com (mail-la0-x229.google.com [IPv6:2a00:1450:4010:c03::229]) by mx1.freebsd.org (Postfix) with ESMTP id EC6A2139A for ; Mon, 22 Apr 2013 20:40:34 +0000 (UTC) Received: by mail-la0-f41.google.com with SMTP id fq13so901543lab.28 for ; Mon, 22 Apr 2013 13:40:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=tDIcmyr0cn0diJo5AG+xR2aRd3v0k8dNO4CXOzu7zhE=; b=NufsMnUeWh7WGpegC1H///qSmQr2WtzR6G1zcLhCs81P38+PYaa08SCt6o7p838stW DYLFMgYr1EPK9U390AOS6QxQDzLjYMq+m8jWyF2J0sGAR0ij3bRCK+l9pZ4C8WPgBcUe KVr/4PKgosYACZtyGyN9O9JCAg3TTnLHpTezZpR6HAqmE3B2U+z1KqtmK5iI8cqKstcr LrSpMgtE5ANfW9JXkYjdQnGVO8UiS7rgVEDWoHAOpPEa5vCLVca/Grk1Cqu7v6V3RY7A cKaax6dSSrl82Qux01cW+yt2ZE5FRrrhQLfopD4vjbZMYmpbTtoRmpf2+5Auli6g3OFf wUGw== X-Received: by 10.112.147.170 with SMTP id tl10mr13775789lbb.100.1366663233928; Mon, 22 Apr 2013 13:40:33 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.152.28.196 with HTTP; Mon, 22 Apr 2013 13:40:13 -0700 (PDT) In-Reply-To: References: <201304220300.r3M301iY093070@freefall.freebsd.org> <51753506.3070901@rewt.org.uk> From: Juli Mallett Date: Mon, 22 Apr 2013 13:40:13 -0700 X-Google-Sender-Auth: uAVQ3HlJ2yxKz0mafDOBH8Zpatc Message-ID: Subject: Re: kern/177876: [mips] kernel stack overflow panic on mips64, EdgeRouter Lite To: Warner Losh Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQlC4ryAXqpNQf0uRiyG7c4m+8m5D99WW64E09JW/dzckiL3Fd1888s/4Q3zymCHSbwDXazU Cc: Joe Holden , "freebsd-mips@FreeBSD.org" X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2013 20:40:35 -0000 On Mon, Apr 22, 2013 at 1:35 PM, Warner Losh wrote: > > On Apr 22, 2013, at 2:29 PM, Juli Mallett wrote: > >> On Mon, Apr 22, 2013 at 1:27 PM, Warner Losh wrote: >>> It sure looks like you are right... I have a full new tree building just to make sure... :( >>> >>> Then again, it would be useful to document where these dependencies lie to help prevent others from tripping over this in the future :( >> >> We should use genassym to generate trapframe offsets instead of having >> hand-coded defines for these, perhaps? I haven't thought it through >> very fully, but that seems a lot better. > > I'll look into this next to ensure that they all match. Can you think of any other places? A quick grep shows nothing obvious... If the header gets nuked, we'll find out fast :) (And I really do think that's the right way forward...)