From owner-svn-src-head@FreeBSD.ORG Tue Oct 14 21:20:52 2008 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E7F9106569B; Tue, 14 Oct 2008 21:20:52 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 00DF68FC17; Tue, 14 Oct 2008 21:20:51 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.local ([192.168.254.200]) (authenticated bits=0) by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id m9EKkriM035017; Tue, 14 Oct 2008 14:47:09 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <48F5053D.7070705@samsco.org> Date: Tue, 14 Oct 2008 14:46:53 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 MIME-Version: 1.0 To: Marius Strobl References: <200810142028.m9EKShoL015514@svn.freebsd.org> In-Reply-To: <200810142028.m9EKShoL015514@svn.freebsd.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=3.8 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r183896 - head/sys/dev/bge X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Oct 2008 21:20:52 -0000 Marius Strobl wrote: > Author: marius > Date: Tue Oct 14 20:28:42 2008 > New Revision: 183896 > URL: http://svn.freebsd.org/changeset/base/183896 > > Log: > Use bus_{read,write}_4(9) instead of bus_space_{read,write}_4(9) > in order to get rid of the bus space handle and tag in the softc. > Has anyone looked at the generated code from this interface switch and compared it what was getting generated previously? Way back when, including made bus_space_read|write_4() compile into a direct memory access on machines that supported it. The dubious removal of bus_memio.h and bus_pio.h took away that benefit, and I'm afraid that it's only getting worse now. Bus writes to card memory are still very important to high-performance devices and shouldn't be pessimized in the name of simpler-looking C code. Scott