From owner-freebsd-ports@FreeBSD.ORG Tue Jan 24 20:24:47 2006 Return-Path: X-Original-To: ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C627516A420; Tue, 24 Jan 2006 20:24:47 +0000 (GMT) (envelope-from laszlof@vonostingroup.com) Received: from ritamari.vonostingroup.com (ritamari.vonostingroup.com [216.144.193.230]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7160343D5F; Tue, 24 Jan 2006 20:24:46 +0000 (GMT) (envelope-from laszlof@vonostingroup.com) Received: from adsl-68-72-248-38.dsl.sfldmi.ameritech.net ([68.72.248.38] helo=[192.168.1.33]) by ritamari.vonostingroup.com with esmtpa (Exim 4.60 (FreeBSD)) (envelope-from ) id 1F1Uif-000DOa-AN; Tue, 24 Jan 2006 15:24:49 -0500 Message-ID: <43D68D0B.4060702@vonostingroup.com> Date: Tue, 24 Jan 2006 15:24:43 -0500 From: Frank Laszlo User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Joe Marcus Clarke References: <6E2E84047A522AA3CF4F3F8D@utd59514.utdallas.edu> <43D65689.8050207@vonostingroup.com> <0CAD779515C871FE2C1AC21E@utd59514.utdallas.edu> <43D661F0.5090802@FreeBSD.org> <9B2BA4ED22481885FB14746D@utd59514.utdallas.edu> <43D68AC7.3020402@FreeBSD.org> In-Reply-To: <43D68AC7.3020402@FreeBSD.org> X-Enigmail-Version: 0.93.2.0 OpenPGP: url=http://www.franksworld.org/~laszlof/keys/0x0B3FCA4B.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ritamari.vonostingroup.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [26 6] X-AntiAbuse: Sender Address Domain - vonostingroup.com X-Source: X-Source-Args: X-Source-Dir: Cc: ports@FreeBSD.org, Paul Schmehl Subject: Re: Something wrong with portlint? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2006 20:24:48 -0000 Joe Marcus Clarke wrote: > Paul Schmehl wrote: > >> --On Tuesday, January 24, 2006 12:20:48 -0500 Joe Marcus Clarke > >> wrote: > >>>>> There has been some extensive port framework changes (see -ports > >>>>> archive) If you send the PR in question, I'd gladly take a look > at it > >>>>> for you. Thanks > >>>>> > >>>> There's actually two - 92239 and 92241 > >>> In 92239, you moved the CATEGORIES line to the wrong location. If you > >>> put CATEGORIES right PORTVERSION, it passes portlint just fine. With > >>> 92241, you have a blank line between PORTVERSION and CATEGORIES. You > >>> can't do that. > >>> > >> I moved them because portlint complained about where they were. That > >> was the entire point of my question. Did you actually run portlint > >> against the PRs? Or are you just assuming from looking at them? > > I actually ran portlint against them. > > >> I know where CATEGORIES is *supposed* to go (according to the Porter's > >> Handbook), but portlint didn't like it there. It kept complaining when > >> it put it where I normally do, which is right after PORTVERSION and > >> right before DISTVERSION, etc. > >> > >> If I do this: > >> PORTNAME= barnyard > >> PORTVERSION= 0.2.0 > >> CATEGORIES= security > >> MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} > >> MASTER_SITE_SUBDIR= barnyard > >> > >> MAINTAINER= pauls@utdallas.edu > >> COMMENT= An output system for Snort > >> > >> I get this: > >> portlint -A > >> WARN: /usr/ports/security/barnyard.new/pkg-plist: Both > >> ``%%PORTDOCS%%@dirrm %%DOCSDIR%%'' and ``%%PORTDOCS%%@unexec > >> %D/%%DOCSDIR%% 2>/dev/null || true'' are missing. At least one should > >> be used. > >> FATAL: Makefile: non-comment line in comment section. > >> WARN: Makefile: for new port, make $FreeBSD$ tag in comment section > >> empty, to make CVS happy. > >> FATAL: Makefile: extra item "MAINTAINER" placed in the PORTNAME > section. > >> FATAL: Makefile: extra item "COMMENT" placed in the PORTNAME section. > >> FATAL: Makefile: PORTNAME has to be there. > >> FATAL: Makefile: PORTVERSION or DISTVERSION has to be there. > >> FATAL: Makefile: CATEGORIES has to be there. > >> FATAL: Makefile: extra item "RUN_DEPENDS" placed in the MAINTAINER > section. > >> FATAL: Makefile: COMMENT has to be there. > >> 10 fatal errors and 2 warnings found. > >> > >> If I do this: > >> PORTNAME= barnyard > >> PORTVERSION= 0.2.0 > >> MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} > >> MASTER_SITE_SUBDIR= barnyard > >> > >> CATEGORIES= security > >> > >> MAINTAINER= pauls@utdallas.edu > >> COMMENT= An output system for Snort > >> > >> I get this: > >> portlint -A > >> WARN: /usr/ports/security/barnyard.new/pkg-plist: Both > >> ``%%PORTDOCS%%@dirrm %%DOCSDIR%%'' and ``%%PORTDOCS%%@unexec > >> %D/%%DOCSDIR%% 2>/dev/null || true'' are missing. At least one should > >> be used. > >> FATAL: Makefile: non-comment line in comment section. > >> WARN: Makefile: for new port, make $FreeBSD$ tag in comment section > >> empty, to make CVS happy. > >> FATAL: Makefile: PORTNAME has to be there. > >> FATAL: Makefile: PORTVERSION or DISTVERSION has to be there. > >> 5 fatal errors and 2 warnings found. > >> > >> Maybe my portlint is screwed up? > > Maybe, I'm using 2.8.3, and as soon as I fixed your PR, portlint liked it. > Put a newline after the "commented" section on the top, all is fine. Like so: # New ports collection makefile for: barnyard # Date created: 1 Feb 2005 # Whom: pauls # # $FreeBSD: ports/security/barnyard/Makefile,v 1.5 2005/11/15 06:50:54 ade Exp $ # PORTNAME= barnyard Cheers, Frank