From owner-freebsd-bugs@FreeBSD.ORG  Tue Nov  9 20:10:30 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DF7FC16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  9 Nov 2004 20:10:30 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D21B843D46
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  9 Nov 2004 20:10:30 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id iA9KAUvS010305
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 9 Nov 2004 20:10:30 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iA9KAUDc010304;
	Tue, 9 Nov 2004 20:10:30 GMT
	(envelope-from gnats)
Date: Tue, 9 Nov 2004 20:10:30 GMT
Message-Id: <200411092010.iA9KAUDc010304@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Vladimir Ivanov <wawa@yandex-team.ru>
Subject: Re: kern/73719: Page fault in bpf_mtap ()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Vladimir Ivanov <wawa@yandex-team.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Nov 2004 20:10:31 -0000

The following reply was made to PR kern/73719; it has been noted by GNATS.

From: Vladimir Ivanov <wawa@yandex-team.ru>
To: freebsd-gnats-submit@FreeBSD.org, wawa@yandex-team.ru
Cc:  
Subject: Re: kern/73719: Page fault in bpf_mtap ()
Date: Tue, 09 Nov 2004 23:02:26 +0300

 Ok,
 The bpf_mtap () seems to be little enough to make a look.
 
 We suppose that most probable reason to panic is zero value of "bp" pointer.
 Also, I know that bpf open/close are frequent on my system.
 We can see (look at BPF_MTAP definition) that the value may be changed 
 from another thread after verification but before bpf_mtap call because 
 "ifp" points to global variable. The patch does not change the logic of 
 program as you can see but garantee "bp" is not NULL. The only side 
 effect is hypotetic pushing extra packet to just detached bpf device. 
 It's not very big price I seem
 
 I've commited the patch to the system and awaiting results.