From owner-p4-projects@FreeBSD.ORG  Wed Mar 31 14:22:39 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C6CE316A4D0; Wed, 31 Mar 2004 14:22:38 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 780EB16A4CF
	for <perforce@freebsd.org>; Wed, 31 Mar 2004 14:22:38 -0800 (PST)
Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4F18F43D49
	for <perforce@freebsd.org>; Wed, 31 Mar 2004 14:22:38 -0800 (PST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 25161 invoked from network); 31 Mar 2004 22:22:37 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx)
	([216.27.160.63])          (envelope-sender <jhb@FreeBSD.org>)
	encrypted SMTP
	for <perforce@freebsd.org>; 31 Mar 2004 22:22:37 -0000
Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i2VMMPDF049237;
	Wed, 31 Mar 2004 17:22:26 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
From: John Baldwin <jhb@FreeBSD.org>
To: Marcel Moolenaar <marcel@FreeBSD.org>
Date: Wed, 31 Mar 2004 17:24:17 -0500
User-Agent: KMail/1.6
References: <200403280714.i2S7Ei6u003786@repoman.freebsd.org>
In-Reply-To: <200403280714.i2S7Ei6u003786@repoman.freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200403311724.17608.jhb@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 49829 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Mar 2004 22:22:39 -0000

On Sunday 28 March 2004 02:14 am, Marcel Moolenaar wrote:
> http://perforce.freebsd.org/chv.cgi?CH=49829
>
> Change 49829 by marcel@marcel_nfs on 2004/03/27 23:14:33
>
> 	Handle the T command. It's sent by gdb to check if a thread
> 	is alive. The command is sent prior to switching to that
> 	thread. This allows us to switch threads in gdb.
>
> Affected files ...
>
> .. //depot/projects/gdb/sys/gdb/gdb_main.c#10 edit
>
> Differences ...
>
> ==== //depot/projects/gdb/sys/gdb/gdb_main.c#10 (text+ko) ====
>
> @@ -193,6 +193,18 @@
>  			kdb_cpu_set_singlestep();
>  			return (1);
>  		}
> +		case 'T': {
> +			intmax_t tid;
> +			pid_t curtid;
> +			gdb_rx_varhex(&tid);
> +			curtid = kdb_thread->td_tid;
> +			if (kdb_set_thread(tid))
> +				gdb_tx_ok();
> +			else
> +				gdb_tx_err(ENOENT);
> +			kdb_set_thread(tid);
> +			break;
> +		}

Don't you want to switch back to curtid here?

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org