Date: Thu, 26 Aug 1999 23:04:44 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Christopher Masto <chris@netmonger.net> Cc: Matthew Dillon <dillon@apollo.backplane.com>, "John W. DeBoskey" <jwd@unx.sas.com>, julian@whistle.com, freebsd-current@freebsd.org Subject: Re: -current kernel problems (spec_getpages & vm_fault) Message-ID: <1161.935701484@critter.freebsd.dk> In-Reply-To: Your message of "Thu, 26 Aug 1999 17:01:52 EDT." <19990826170152.A8492@netmonger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <19990826170152.A8492@netmonger.net>, Christopher Masto writes:
>On Thu, Aug 26, 1999 at 10:35:27PM +0200, Poul-Henning Kamp wrote:
>> In message <199908262013.NAA24637@apollo.backplane.com>, Matthew Dillon writes:
>> > That fixes a problem with ccd, but not the one causing John's failures.
>> >
>> > You will note that with John's failure's the I/O is properly page-aligned.
>> > The fix to ccd deals with a misalignment problem.
>>
>> No it doesn't. johns failure is clearly the si_bsize* problem, the
>> tell-tale sign is all the zeros in there. What John didn't tell
>> us is if he uses vn, ccd or vinum (or something else!)
>
>Well, I just had much the same blowup with source from last night
>and I'm using vinum, (and not vn or ccd).
>
>Recompiling now to see if it's still there.
Ok, I havn't touched vinum (grog generally want to do this himself),
the fix is probably something like this:
Index: vinum.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/vinum/vinum.c,v
retrieving revision 1.29
diff -u -r1.29 vinum.c
--- vinum.c 1999/08/24 02:18:55 1.29
+++ vinum.c 1999/08/26 21:04:03
@@ -271,6 +271,9 @@
int devminor; /* minor number */
devminor = minor(dev);
+ dev->si_bsize_phys = DEV_BSIZE;
+ dev->si_bsize_best = BLKDEV_IOSIZE;
+ dev->si_bsize_max = MAXBSIZE;
error = 0;
/* First, decide what we're looking at */
switch (DEVTYPE(dev)) {
--
Poul-Henning Kamp FreeBSD coreteam member
phk@FreeBSD.ORG "Real hackers run -current on their laptop."
FreeBSD -- It will take a long time before progress goes too far!
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1161.935701484>