From owner-p4-projects@FreeBSD.ORG  Sun Sep 13 12:06:13 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E0F2D10656CB; Sun, 13 Sep 2009 12:06:12 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A551110656C7
	for <perforce@FreeBSD.org>; Sun, 13 Sep 2009 12:06:12 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 7BF968FC17
	for <perforce@FreeBSD.org>; Sun, 13 Sep 2009 12:06:12 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n8DC6COE005976
	for <perforce@FreeBSD.org>; Sun, 13 Sep 2009 12:06:12 GMT
	(envelope-from hselasky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n8DC6C3u005974
	for perforce@freebsd.org; Sun, 13 Sep 2009 12:06:12 GMT
	(envelope-from hselasky@FreeBSD.org)
Date: Sun, 13 Sep 2009 12:06:12 GMT
Message-Id: <200909131206.n8DC6C3u005974@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	hselasky@FreeBSD.org using -f
From: Hans Petter Selasky <hselasky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 168496 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Sep 2009 12:06:13 -0000

http://perforce.freebsd.org/chv.cgi?CH=168496

Change 168496 by hselasky@hselasky_laptop001 on 2009/09/13 12:05:14

	
	usbconfig:
	  - add more verbose output when dumping the configuration
	  descriptor.

Affected files ...

.. //depot/projects/usb/src/usr.sbin/usbconfig/dump.c#14 edit

Differences ...

==== //depot/projects/usb/src/usr.sbin/usbconfig/dump.c#14 (text+ko) ====

@@ -100,21 +100,66 @@
 
 	printf("%s%s = 0x%04x ", plevel, field, value);
 
-	if ((field[0] != 'i') || (field[1] == 'd')) {
-		printf("\n");
-		return;
+	if (strlen(plevel) == 8) {
+		/* Endpoint Descriptor */
+
+		if (strcmp(field, "bEndpointAddress") == 0) {
+			if (value & 0x80)
+				printf("<IN>\n");
+			else
+				printf("<OUT>\n");
+			return;
+		}
+
+		if (strcmp(field, "bmAttributes") == 0) {
+			switch (value & 0x03) {
+			case 0:
+				printf("<CONTROL>\n");
+				break;
+			case 1:
+				switch (value & 0x0C) {
+				case 0x00:
+					printf("<ISOCHRONOUS>\n");
+					break;
+				case 0x04:
+					printf("<ASYNC-ISOCHRONOUS>\n");
+					break;
+				case 0x08:
+					printf("<ADAPT-ISOCHRONOUS>\n");
+					break;
+				default:
+					printf("<SYNC-ISOCHRONOUS>\n");
+					break;
+				}
+				break;
+			case 2:
+				printf("<BULK>\n");
+				break;
+			default:
+				printf("<INTERRUPT>\n");
+				break;
+			}
+			return;
+		}
 	}
-	if (value == 0) {
-		printf(" <no string>\n");
+
+	if ((field[0] == 'i') && (field[1] != 'd')) {
+		/* Indirect String Descriptor */
+		if (value == 0) {
+			printf(" <no string>\n");
+			return;
+		}
+		if (libusb20_dev_req_string_simple_sync(pdev, value,
+		    temp_string, sizeof(temp_string))) {
+			printf(" <retrieving string failed>\n");
+			return;
+		}
+		printf(" <%s>\n", temp_string);
 		return;
 	}
-	if (libusb20_dev_req_string_simple_sync(pdev, value,
-	    temp_string, sizeof(temp_string))) {
-		printf(" <retrieving string failed>\n");
-		return;
-	}
-	printf(" <%s>\n", temp_string);
-	return;
+
+	/* No additional information */
+	printf("\n");
 }
 
 static void