From owner-cvs-all Sun Nov 19 12:46:32 2000 Delivered-To: cvs-all@freebsd.org Received: from feral.com (feral.com [192.67.166.1]) by hub.freebsd.org (Postfix) with ESMTP id 97ACD37B479; Sun, 19 Nov 2000 12:46:27 -0800 (PST) Received: from zeppo.feral.com (IDENT:mjacob@zeppo [192.67.166.71]) by feral.com (8.9.3/8.9.3) with ESMTP id MAA22469; Sun, 19 Nov 2000 12:46:24 -0800 Date: Sun, 19 Nov 2000 12:46:17 -0800 (PST) From: Matthew Jacob Reply-To: mjacob@feral.com To: Alfred Perlstein Cc: Doug Rabson , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha clock.c db_interface.c interrupt.c mp_machdep.c prom.c vm_machdep.c In-Reply-To: <20001119124403.M18037@fw.wintelcom.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 19 Nov 2000, Alfred Perlstein wrote: > * Doug Rabson [001119 04:29] wrote: > > dfr 2000/11/19 04:28:42 PST > > > > Modified files: > > sys/alpha/alpha clock.c db_interface.c interrupt.c > > mp_machdep.c prom.c vm_machdep.c > > Log: > > Convert various calls to splhigh() to disable_intr() since splhigh() is > > now a no-op. > > Afaik the concensus was that spl's were not to be removed even > though they are no-ops. > > You should probably put them back. No, actually they're needed and they are there. This is all specifically machine dependent code areas, and places where, for example, the prom is entered, interrupts really do need to be disabled. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message