From owner-freebsd-ports-bugs@freebsd.org Tue Sep 20 11:08:15 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84383BE279D for ; Tue, 20 Sep 2016 11:08:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5987DB75 for ; Tue, 20 Sep 2016 11:08:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u8KB8ET5012058 for ; Tue, 20 Sep 2016 11:08:15 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 212849] games/osgg: Unbreak fetch, improve Date: Tue, 20 Sep 2016 11:08:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: amdmi3@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter cc flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 11:08:15 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212849 Bug ID: 212849 Summary: games/osgg: Unbreak fetch, improve Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: amdmi3@FreeBSD.org Reporter: lightside@gmx.com CC: amdmi3@FreeBSD.org Attachment #174999 maintainer-approval?(amdmi3@FreeBSD.org) Flags: Flags: maintainer-feedback?(amdmi3@FreeBSD.org) Assignee: amdmi3@FreeBSD.org CC: amdmi3@FreeBSD.org Created attachment 174999 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D174999&action= =3Dedit Proposed patch (since 422447 revision) Patch to unbreak games/osgg and improve port. - Unbreak fetch with using available distfile - Adapt WRKSRC value - Remove -f argument near ${RM} value - Put cd related commands in parenthesis - Regenerate distinfo file with using `make makesum` command and correct TIMESTAMP value Note about parenthesis for cd related commands: -8<-- man make | grep "in parenthesis" -h5 | tail -8 Makefiles should be written so that the mode of make operation does not change their behavior. For example, any command which needs to use "c= d" or "chdir", without side-effect should be put in parenthesis: avoid-chdir-side-effects: @echo Building $@ in `pwd` @(cd ${.CURDIR} && ${.MAKE} $@) -->8- Note about ${RM} value and -f argument: -8<-- make -C /usr/ports -V RM /bin/rm -f -->8- How TIMESTAMP value was generated (for this case): make clean extract && find work/* -type f -print0 | xargs -0 stat -f '%m' | sort -u | tail -1 && make clean or make clean extract && find work/* -type f -exec stat -f '%m' {} + | sort -u= | tail -1 && make clean --=20 You are receiving this mail because: You are the assignee for the bug.=