From owner-freebsd-current Wed May 29 16:53:50 2002 Delivered-To: freebsd-current@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id D5D9637B408; Wed, 29 May 2002 16:53:42 -0700 (PDT) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.3/8.12.3) with ESMTP id g4TNrd4j063968; Wed, 29 May 2002 16:53:40 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.3/8.12.3/Submit) id g4TNrdH7063967; Wed, 29 May 2002 16:53:39 -0700 (PDT) (envelope-from dillon) Date: Wed, 29 May 2002 16:53:39 -0700 (PDT) From: Matthew Dillon Message-Id: <200205292353.g4TNrdH7063967@apollo.backplane.com> To: "J. Mallett" Cc: "David O'Brien" , Julian Elischer , John Baldwin , FreeBSD current users Subject: Re: Seeking OK to commit KSE MIII References: <20020529124434.A2156@dragon.nuxi.com> <200205292007.g4TK71YD062671@apollo.backplane.com> <20020529152159.A82752@FreeBSD.ORG> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG : :When you make the code more readable, you introduce further diffs, and you :leave no reference against the original code of where the functional changes :are. Either make the "base" code cleaned up by committing non-functional :changes first, or commit against the "base" code your functional changes, :and then clean it up. Otherwise, it's a pain in the ass to sort things out. : :And for what it's worth, I'm all for readability improvements in our code, I :just also like to go and view diffs sometimes and try to figure out what's :changed. : :But I think you're also right on the rule of thumb thing, if someone does not :want to do this favor to everyone who might want to read diffs or annotate :changes to the code and get something meaningful, that's fine. I've done it Oh come on, that is not what I meant at all and you know it. What is this junk about 'not wanting to do this favor to everyone'? I never said that. I didn't even come CLOSE to saying that or infering that. It is complete and utter bullshit and a severe... nay, *EXTREME* twisting of what I said. You missed the point entirely. Go back and READ WHAT I WROTE. I made it pretty damn clear. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message