From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue Oct 23 12:31:10 2012
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 375232A4;
 Tue, 23 Oct 2012 12:31:10 +0000 (UTC)
 (envelope-from jaap@NLnetLabs.nl)
Received: from bela.nlnetlabs.nl (bela.nlnetlabs.nl
 [IPv6:2001:7b8:206:1:222:4dff:fe55:4ccb])
 by mx1.freebsd.org (Postfix) with ESMTP id BDDFE8FC18;
 Tue, 23 Oct 2012 12:31:09 +0000 (UTC)
Received: from NLnetLabs.nl (localhost [127.0.0.1])
 by bela.nlnetlabs.nl (8.14.5/8.14.5) with ESMTP id q9NCV2ab074056;
 Tue, 23 Oct 2012 14:31:02 +0200 (CEST)
 (envelope-from jaap@NLnetLabs.nl)
Message-Id: <201210231231.q9NCV2ab074056@bela.nlnetlabs.nl>
To: Erwin Lansing <erwin@FreeBSD.org>
Subject: Re: ports/172903: dns/opendnssec convert to OPTIONSNG
In-reply-to: <20121023095255.GM4474@droso.net>
References: <201210211803.q9LI3aCV044793@freefall.freebsd.org>
 <20121023095255.GM4474@droso.net>
Comments: In-reply-to Erwin Lansing <erwin@FreeBSD.org>
 message dated "Tue, 23 Oct 2012 11:52:56 +0200."
Date: Tue, 23 Oct 2012 14:31:02 +0200
From: Jaap Akkerhuis <jaap@NLnetLabs.nl>
X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,MISSING_MID
 autolearn=no version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on bela.nlnetlabs.nl
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.7
 (bela.nlnetlabs.nl [127.0.0.1]); Tue, 23 Oct 2012 14:31:07 +0200 (CEST)
Cc: freebsd-ports-bugs@FreeBSD.org
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2012 12:31:10 -0000

Hoi Erwin,

    If I'm diffing the diffs correctly, you used the first version of
    my patch to send the new one and the main change you made was to
    move the ruby check back to the bottem after the inclusion of
    bsd.port.post.mk.

Yes.

    My second patch, attached for completeness, actually did the same,

I didn't realise the differences between the two and I used the first
because I could download that one. It also worked. (The second didn't.
Not being ean attachment, it got butchered somewhere.)

    but also moved the OPTIONS_* macros before including
    bsd.port.options.mk, which is the recommended way. Is this patch
    fine with you, or did I overlook anything?

This is fine with me, no problem. (And, for good measures, I tested it
on my test tinderboxes).

Thanks!

	jaap