From owner-freebsd-ports@FreeBSD.ORG Sat May 23 10:51:06 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA2301065741; Sat, 23 May 2009 10:51:06 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98]) by mx1.freebsd.org (Postfix) with ESMTP id 7F6A28FC17; Sat, 23 May 2009 10:51:06 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from it.buh.tecnik93.com (localhost [127.0.0.1]) by it.buh.tecnik93.com (Postfix) with ESMTP id 88D172C50CC1; Sat, 23 May 2009 13:51:33 +0300 (EEST) Date: Sat, 23 May 2009 13:51:33 +0300 From: Ion-Mihai Tetcu To: Maho NAKATA Message-ID: <20090523135133.71a92669@it.buh.tecnik93.com> In-Reply-To: <20090523.182426.193741786.chat95@mac.com> References: <20090522.195350.193746535.chat95@mac.com> <20090522164138.236cb114@it.buh.tecnik93.com> <200905231101.59467.naylor.b.david@gmail.com> <20090523.182426.193741786.chat95@mac.com> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.1; i386-portbld-freebsd7.1) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/BS.66kOxQ4I9KX8OCANu19K"; protocol="application/pgp-signature" Cc: pgollucci@p6m7g8.com, pav@FreeBSD.org, naylor.b.david@gmail.com, freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2009 10:51:07 -0000 --Sig_/BS.66kOxQ4I9KX8OCANu19K Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 23 May 2009 18:24:26 +0900 (JST) Maho NAKATA wrote: > Hi David >=20 > Many many thanks for your patch. I'll test it very soon. >=20 > Just one comment > > I believe openoffice-2* can me marked as SAFE while openoffice-3* > > should not be marked at all (since it sometimes works..., very well > > for me :-). > you can mark as SAFE for all of our ports.=20 For testing, right? > If it's broken, its OOo issue. Obviously. > We should identify if dependencies are missing. -devel ports can be > unsafe but 3, 3-RC 2, 2-RC must be safe. >=20 > Please wait a few days to say ok. I'll give them a try during this weekend. > From: David Naylor > Subject: Re: MAKE_JOBS_UNSAFE (some more ports) > Date: Sat, 23 May 2009 11:01:56 +0200 [ .. ] > > Please see attached for the patch. The changes to bsd.port.mk: > > - MAKE_JOBS_NUMBER always defined > > - MAKE_JOBS_NUMBER forced to 1 if UNSAFE of DISABLE AFAIR there are ports that compile OK w/o MAKE_JOBS_SAFE but fail with MAKE_JOBS_NUMBER=3D1 > > - MAKE_JOBS_NUMBER defaults (but user defined) to number of cores This part looks OK, I wonder if there's any reason t ain't like this now; Pav? -.if defined(MAKE_JOBS_NUMBER) +MAKE_JOBS_NUMBER?=3D `${SYSCTL} -n kern.smp.cpus` _MAKE_JOBS=3D -j${MAKE_JOBS_NUMBER} -.else -_MAKE_JOBS=3D -j`${SYSCTL} -n kern.smp.cpus` -.endif I believe pav@ didn't put the ' && !defined(MAKE_JOBS_SAFE)' part intentionally until we get to test all our ports. -.if defined(FORCE_MAKE_JOBS) +.if defined(FORCE_MAKE_JOBS) && !defined(MAKE_JOBS_SAFE) BUILD_FAIL_MESSAGE+=3D "You have chosen to use multiple make jobs (paralle= lization) for all ports. This port was not tested for this setting. Pleas= e remove FORCE_MAKE_JOBS and retry the build before reporting the failure t= o the maintainer." > > I've then used MAKE_JOBS_NUMBER to set MAXPROCESSES, MAXMODULES and > > NUMOFPROCESSES for openoffice-* (not including 1.*). > > > > I believe openoffice-2* can me marked as SAFE while openoffice-3* > > should not be marked at all (since it sometimes works..., very well > > for me :-). > > > > This patch just makes openoffice-* behave like other ports in > > regards to parallel builds and the usual MAKE_JOBS variables now > > works as expected. Nice, thanks. --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/BS.66kOxQ4I9KX8OCANu19K Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkoX1TUACgkQJ7GIuiH/oeW2FgCdFScg3lBmjYt1fNiGJAYR6pud XyoAn3QyeS/xxYPJOEgAcZrmGJjEovuy =FblI -----END PGP SIGNATURE----- --Sig_/BS.66kOxQ4I9KX8OCANu19K--