Date: Thu, 5 Dec 2013 22:54:37 +0100 From: "A.J. 'Fonz' van Werven" <freebsd@skysmurf.nl> To: freebsd-stable@freebsd.org, freebsd-ports@freebsd.org Subject: [games/ofortune] CFT and pending issues Message-ID: <20131205215437.GA32134@spectrum.skysmurf.nl>
next in thread | raw e-mail | index | archive | help
--17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable A short recap for those of you who are subscribed to freebsd-ports@ but not freebsd-stable@: when I opened my inbox this morning I found a typical WTF thread: the (hardly) "offensive" fortune cookies have been kicked out of 10-BETA4. Since I (and many others) find this Just Plain Stupid (tm) I created a port to bring some sanity back into fortune(6). Anyone running FreeBSD 10-BETA4 feel free to test the port and comment on it before I file the PR asking for it to be committed. A shar "patch" can be found here: http://www.skysmurf.nl/comp/FreeBSD/files/ofortune.shar Or alternatively, a tarball can be found in the same place: http://www.skysmurf.nl/comp/FreeBSD/files/ofortune.tar.gz To extract the shar file: # cd /usr/ports/games # sh /path/to/shar-file Or alternatively, to extract the tarball: # cd /usr/ports/games # tar xzvf /path/to/tarball Install via your favourite method, e.g. # cd /usr/ports/games/ofortune # make install or # portmaster games/ofortune PENDING ISSUES: -1- It's tentatively called ofortune. If you can think of a better name, then by all means shoot. -2- The accompanying webpage is crap. This is no priority ;-) -3- I have found the instructions for changing and/or adding to the fortune files but haven't tested them yet. -4- I wanted to mark the port as IGNORE for versions of FreeBSD prior to 10-BETA4. But this breaks stuff (see point 6) and I need to know exactly what the version number (OSVERSION) is for 10-BETA4. -5- Currently the port installs the "offensive" fortunes into /usr/local/share/ofortune, requiring every user to add that directory to their FORTUNE_PATH (hence the pkg-message). I tried adding an OPTION that would install it into the base /usr/share/games/fortune, but that again breaks stuff, see point 6. -6- It appears that for some reason conditionals don't work in the Makefile. For your reference, I have added the Makefile below, with the parts commented out that I think should work but don't. In both cases I get "Malformed conditional" errors. Any thoughts? Regards, AvW (fonz) [begin /usr/ports/games/ofortune/Makefile] # $FreeBSD$ PORTNAME=3D ofortune PORTVERSION=3D 0.99.0 CATEGORIES=3D games MASTER_SITES=3D http://www.skysmurf.nl/comp/FreeBSD/distfiles/ MAINTAINER=3D freebsd@skysmurf.nl COMMENT=3D The offensive fortune cookies that used to be in base. ### # This is supposed to work but doesn't. ### #OPTIONS_DEFINE=3D BASE #OPTIONS_DEFAULT=3D #BASE_DESC=3D To install into the base system rather than /usr/local. # #.include <bsd.port.options.mk> # #.if ${PORT_OPTIONS:BASE} #DATADIR=3D /usr/share/games/fortune #.else PLIST_DIRS=3D ${DATADIR} #.endif PLIST_FILES=3D ${DATADIR}/fortunes-o \ ${DATADIR}/fortunes-o.dat \ ${DATADIR}/murphy-o \ ${DATADIR}/murphy-o.dat NO_BUILD=3D yes NO_INSTALL=3D yes ### # This is supposed to work but doesn't. # # 702106 has been copied from an example, I need the right number for 10-BE= TA4. # #.if ${OSVERSION} < 702106 #IGNORE=3D For versions prior to 10-BETA4 this is still in base. #.endif ### post-install: ${MKDIR} ${STAGEDIR}${DATADIR} ${INSTALL_DATA} ${WRKSRC}/* ${STAGEDIR}${DATADIR} =2Einclude <bsd.port.mk> [end /usr/ports/games/ofortune/Makefile] --=20 I'm not completely useless, I can be used as a bad example. --17pEHd4RhPHOinZp Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSoPYdAAoJEAfP7gJTaCe8FxsQAN0l7h2dpBQWE+EDXX20aHDU 2TdzDY9s9KPpIQcwkaqJqrA3aLlxCI88CPnlOui+GOHMpiiQnT/Gbz5AumRtEjlF SKt95mxK02LfwBAdZuTyNMd7FJb9fsTm3BF0vnbB32bPJ6AW0HeuQT8bF6IKaKXV JIkkjWfDhSwk0911419GEt83msuACG8PTTHp+Z8kFXJ+ZYKM8fQd8mYdZOLmOnye axR2WdqSHg4suh3nWyHPPeekUTgbAv9ixRyRO6AvRvbKVJc0EVvmYn7yVKSXZ+rY VXwIOCls0xWebB0RPiz7it9l6zfghnpyj+deZ1t5bBGJgWT8ga+7B4dV/gnIEI9y 6hvp0PkujZSRmMPv8elSe6RtSVlSo+dELfK3rDd1pZQKjlR5M588abPSRXFJzzh9 vhowHg1Cxl+X+Jd4GtOwntp5SgB9DU9c5ORfv8UyrpFHTvpc3/3PdLMQ8OJvmye0 XGIvVMbf7xkCvoO7jU3Qi09kAhuPkzf4V20uHLWzfyvaLXLuPSGyAi0x5jJq+68z U1CKYSHmgUlqUBbuX5ndx69jFluVqJRRNpNkBPndroxZJQdnifbvI5waUNJXEMxU xTOGAUOVRAj+KMh41bPFxfaIZs4jQdmqX8og4mOxjRz8kIYPWGriQG1T5HSXKiCB 3+t8+7w96cC6L8pg4smw =5FVA -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131205215437.GA32134>