Date: Fri, 01 Aug 2014 08:13:53 +0200 From: John Marino <freebsd.contact@marino.st> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Antoine Brodin <antoine@FreeBSD.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, Max Brazhnikov <makc@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, John Marino <marino@freebsd.org>, William Grzybowski <wg@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Mathieu Arnold <mat@freebsd.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r363361 - in head/editors/fte: . files Message-ID: <53DB3021.7010909@marino.st> In-Reply-To: <20140801060506.GA71116@FreeBSD.org> References: <3898057.T8DsoXnEEp@mercury.ph.man.ac.uk> <53D89EBF.4080805@marino.st> <2D24420529C9ECAEABB9A791@atuin.in.mat.cc> <53D8A2BB.7090704@marino.st> <6270029E710D3C52B60B6224@atuin.in.mat.cc> <20140730081413.GA29876@FreeBSD.org> <20140730160843.GA2688@FreeBSD.org> <53D919BC.6010307@marino.st> <20140801051652.GA59625@FreeBSD.org> <CAALwa8=R2i9PA7R8VXHStZCDGy_ZFaYcBtRmY-_ZFq9k=toJ%2Bw@mail.gmail.com> <20140801060506.GA71116@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/1/2014 08:05, Alexey Dokuchaev wrote:
> On Fri, Aug 01, 2014 at 08:02:21AM +0200, Antoine Brodin wrote:
>> Refusing _ in seperator seems total bullshit, this convention has
>> been in place for 9 years, wtf!?
>
> ... PATCH_PATH_SEPARATOR must be one of the [-+_] characters. Where am I
> refusing _?
>
> ./danfe
>
I suspect he means "__" not "_"
logic flaw: You can't just replace "/" with "-" or "_" without altering
"-" or "_" in the filename.
example, given these files:
${WRKSRC}/alpha-bravo
${WRKSRC}/alpha/bravo
if you replace "/" with "-", both have the same suggested patch name.
You need to alter the hyphen in alpha-bravo first. Maybe this is an
existing logic flaw in makepatch.
And no, this is not contrived. I've actually run into this.
So what would this version of makepatch do with my example?
John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53DB3021.7010909>