Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Aug 2010 16:53:35 +0200
From:      Gary Jennejohn <gljennjohn@googlemail.com>
To:        "Julian H. Stacey" <jhs@berklix.com>
Cc:        ports@FreeBSD.org, lihong@ieee.org, mono@FreeBSD.org
Subject:   Re: FETCH_ARGS -a in Makefile of www/moonshine & chinese/ibus-chewing
Message-ID:  <20100823165335.4985ebba@ernst.jennejohn.org>
In-Reply-To: <201008231303.o7ND3CpF069945@fire.js.berklix.net>
References:  <201008231303.o7ND3CpF069945@fire.js.berklix.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Aug 2010 15:03:11 +0200
"Julian H. Stacey" <jhs@berklix.com> wrote:

> Hi mono@FreeBSD.org, lihong@ieee.org
> cc: ports@freebsd.org
> I didn't use send-pr with a diff for this [yet], as review requested [first].
> 
> In 
> 	-current/ports/www/moonshine/Makefile		FETCH_ARGS=   -apRr
> 	-current/ports/chinese/ibus-chewing/Makefile 	FETCH_ARGS=   -apRr
> please remove 
> 	'a' 
> from 
> 	FETCH_ARGS
> (or perhaps its better to remove the whole line?) 
> 

The real bug here is that the ports should have FETCH_ARGS?=, like in
/usr/ports/Mk/bsd.port.mk, so that any value which the user sets won't
be overidden by the port.

--
Gary Jennejohn



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100823165335.4985ebba>