From owner-cvs-all Sun Nov 19 13: 5: 5 2000 Delivered-To: cvs-all@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id 0E76D37B4C5; Sun, 19 Nov 2000 13:00:45 -0800 (PST) Received: from grondar.za (grapevine.grondar.za [196.7.18.17]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id eAJKwpJ16191; Sun, 19 Nov 2000 22:58:51 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200011192058.eAJKwpJ16191@gratis.grondar.za> To: Alfred Perlstein Cc: Doug Rabson , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha clock.c db_interface.c interrupt.c mp_machdep.c prom.c vm_machdep.c References: <20001119124403.M18037@fw.wintelcom.net> In-Reply-To: <20001119124403.M18037@fw.wintelcom.net> ; from Alfred Perlstein "Sun, 19 Nov 2000 12:44:04 PST." Date: Sun, 19 Nov 2000 22:58:49 +0200 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > Convert various calls to splhigh() to disable_intr() since splhigh() is > > now a no-op. > > Afaik the concensus was that spl's were not to be removed even > though they are no-ops. > > You should probably put them back. I remember this more as leaving them there as "markers" until they got dealt with properly. The above commit looks like "properly" to me. M -- Mark Murray Join the anti-SPAM movement: http://www.cauce.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message