Date: Thu, 26 Feb 2009 09:45:28 +0100 From: Ed Schouten <ed@80386.nl> To: Andrew Thompson <thompsa@FreeBSD.org> Cc: usb@freebsd.org, current@freebsd.org, Hans Petter Selasky <hselasky@c2i.net> Subject: Re: USB devfs patch Message-ID: <20090226084528.GU19161@hoeg.nl> In-Reply-To: <20090226020330.GC25211@citylink.fud.org.nz> References: <20090226020330.GC25211@citylink.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
--TYoqghpzCwoKvQG2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andrew, * Andrew Thompson <thompsa@FreeBSD.org> wrote: > Below is a patch from Rink Springer to change the new USB stack to use > devfs device nodes. I have tested this with a usb mouse and I am hoping > people with other devices can test too, in particular scanners (sane > app) and lpt ports. I also mentioned this on IRC, but just to make sure it won't get lost. I really like the patch. I just tried it and it seems to work as advertised. What's your opinion on this patch? http://80386.nl/pub/usb-cdev.diff It turns the d_fdopen() function to a regular d_open(). I think we should only use d_fdopen() in cases where we really need access to the file descriptor (like ptmx). --=20 Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ --TYoqghpzCwoKvQG2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmmVqgACgkQ52SDGA2eCwXQ7ACeJHtydVjx6ylLmo4RVdz5qVHj BxIAn2jPaDObeUql6QV6wMDaGL1s1Sph =ft0H -----END PGP SIGNATURE----- --TYoqghpzCwoKvQG2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090226084528.GU19161>