From owner-cvs-src@FreeBSD.ORG Thu Mar 24 21:07:12 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95DA016A4CF for ; Thu, 24 Mar 2005 21:07:12 +0000 (GMT) Received: from mail22.sea5.speakeasy.net (mail22.sea5.speakeasy.net [69.17.117.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0A2F43D1D for ; Thu, 24 Mar 2005 21:07:11 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 17845 invoked from network); 24 Mar 2005 21:07:11 -0000 Received: from server.baldwin.cx ([216.27.160.63]) (envelope-sender )AES256-SHA encrypted SMTP for ; 24 Mar 2005 21:07:07 -0000 Received: from [10.50.41.231] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j2OL71IP071923; Thu, 24 Mar 2005 16:07:02 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Stefan Farfeleder Date: Thu, 24 Mar 2005 16:08:40 -0500 User-Agent: KMail/1.6.2 References: <200503241751.j2OHpFQg063306@repoman.freebsd.org> <200503241555.59177.jhb@FreeBSD.org> <20050324210504.GL46915@wombat.fafoe.narf.at> In-Reply-To: <20050324210504.GL46915@wombat.fafoe.narf.at> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Message-Id: <200503241608.40625.jhb@FreeBSD.org> X-Spam-Status: No, score=-102.8 required=4.2 tests=ALL_TRUSTED, USER_IN_WHITELIST autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx cc: Brooks Davis cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2005 21:07:12 -0000 On Thursday 24 March 2005 04:05 pm, Stefan Farfeleder wrote: > On Thu, Mar 24, 2005 at 03:55:59PM -0500, John Baldwin wrote: > > On Thursday 24 March 2005 03:19 pm, Brooks Davis wrote: > > > On Thu, Mar 24, 2005 at 09:09:43PM +0100, Stefan Farfeleder wrote: > > > > On Thu, Mar 24, 2005 at 12:02:10PM -0800, Brooks Davis wrote: > > > > > Prior to C99, I think #error wasn't specified. C99 does specify > > > > > it. > > > > > > > > C89/90 had #error too. > > > > > > I stand corrected. Now that I think about it, all but the perverse > > > preprocessors would implement #error just by blowing up on an unknown > > > directive so even that isn't an issue. In any case, I've made the > > > change and the new code is at least shorter. It's really only there > > > for people mucking with kernel internals who should be able to figure > > > out what it means. > > > > We could always just change CTASSERT() to use #error if that is better. > > Unfortunately you can't use preprocessor directives in the replacement > list of a macro. Ah, doh. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org