From owner-cvs-all Wed Feb 3 20:24:38 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA09266 for cvs-all-outgoing; Wed, 3 Feb 1999 20:24:38 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from zibbi.mikom.csir.co.za (zibbi.mikom.csir.co.za [146.64.24.58]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA09173; Wed, 3 Feb 1999 20:24:22 -0800 (PST) (envelope-from jhay@zibbi.mikom.csir.co.za) Received: (from jhay@localhost) by zibbi.mikom.csir.co.za (8.9.1/8.9.1) id GAA19751; Thu, 4 Feb 1999 06:24:04 +0200 (SAT) From: John Hay Message-Id: <199902040424.GAA19751@zibbi.mikom.csir.co.za> Subject: Re: cvs commit: src/sys/pci pcisupport.c In-Reply-To: <19990203225457.36356@breizh.prism.uvsq.fr> from Nicolas Souchu at "Feb 3, 99 10:54:57 pm" To: nsouch@teaser.fr (Nicolas Souchu) Date: Thu, 4 Feb 1999 06:24:04 +0200 (SAT) Cc: peter@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL32 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Are you sure that it breaks? It is working here on -current with r 1.90 of pcisupport.c on a single processor Asus motherboard. On a SMP machine it panics during the probing/attaching of the intpm device in INTREN. :-( But it also did print the first two lines of the intpm probe messages, so it would seem like the pcisupport part working properly there too? John -- John Hay -- John.Hay@mikom.csir.co.za > On Mon, Jan 25, 1999 at 08:54:39PM -0800, Peter Wemm wrote: > > > >peter 1999/01/25 20:54:38 PST > > > > Modified files: > > sys/pci pcisupport.c > > Log: > > Check if the intpm controller is configured first before stopping > > recognition of the 82371AB device. > > > > Revision Changes Path > > 1.88 +7 -2 src/sys/pci/pcisupport.c > > > > What was the problem with the NULL return if intpm does not exist? > > The solution you propose breaks the intpm code. > > Nicholas. > > -- > nsouch@teaser.fr / nsouch@freebsd.org > FreeBSD - Turning PCs into workstations - http://www.FreeBSD.org > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message