From owner-cvs-all Mon Oct 14 14:15:11 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 97D9037B404; Mon, 14 Oct 2002 14:15:10 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 44BA543ED8; Mon, 14 Oct 2002 14:15:05 -0700 (PDT) (envelope-from alfred@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id g9ELF4Mt088229; Mon, 14 Oct 2002 14:15:04 -0700 (PDT) (envelope-from alfred@repoman.freebsd.org) Received: (from alfred@localhost) by repoman.freebsd.org (8.12.6/8.12.3/Submit) id g9ELF4Pv088228; Mon, 14 Oct 2002 14:15:04 -0700 (PDT) Message-Id: <200210142115.g9ELF4Pv088228@repoman.freebsd.org> From: Alfred Perlstein Date: Mon, 14 Oct 2002 14:15:04 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern sys_pipe.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG alfred 2002/10/14 14:15:04 PDT Modified files: sys/kern sys_pipe.c Log: Remove a KASSERT I added in 1.73 to catch uninitialized pipes. It must be removed because it is done without the pipe being locked via pipelock() and therefore is vulnerable to races with pipespace() erroneously triggering it by temporarily zero'ing out the structure backing the pipe. It looks as if this assertion is not needed because all manipulation of the data changed by pipespace() _is_ protected by pipelock(). Reported by: kris, mckusick Revision Changes Path 1.124 +0 -2 src/sys/kern/sys_pipe.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message