Date: Tue, 3 Jun 2003 14:47:18 +0100 From: Paul Richards <paul@freebsd-services.com> To: Hiten Pandya <hmp@FreeBSD.ORG> Cc: des@FreeBSD.ORG Subject: Re: VFS: C99 sparse format for struct vfsops Message-ID: <20030603134717.GD35187@survey.codeburst.net> In-Reply-To: <20030602160411.GA24490@perrin.int.nxad.com> References: <20030602014757.GA99626@perrin.int.nxad.com> <3EDB6A6F.827B7C22@mindspring.com> <20030602160411.GA24490@perrin.int.nxad.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 02, 2003 at 09:04:11AM -0700, Hiten Pandya wrote: > On Mon, Jun 02, 2003 at 08:17:03AM -0700, Terry Lambert wrote: > > Hiten Pandya wrote: > > > My fingers have been itching to do this since the day phk@ planted this > > > idea in my brain (re: cdevsw initialisations). Basically, it changes > > > the vfsops to use C99 sparse format, just like cdevsw. It removes a lot > > > of junk default initialisations, and duplication. > > > > I really dislike the changes to vfs_init(). Specifically, it's > > not the overhead, so much as it's the implied side effects. > > And how many times is vfc_register() called? Its not in the > patch of an I/O operation or anything. Its just a mount time > overhead which will go through -- a one time thing. > > > Consider this going forward: someone adds a new VFSOP to the > > list of allowable VFSOPs, and the vfs_init() doesn't have any > > specific code for it. You should look at kobj, it's precisely this sort of dynamic dispatching that it was designed to support. -- Tis a wise thing to know what is wanted, wiser still to know when it has been achieved and wisest of all to know when it is unachievable for then striving is folly. [Magician]
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030603134717.GD35187>