From owner-cvs-ports@FreeBSD.ORG  Fri Jul  9 10:02:31 2010
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 94C0F106564A;
	Fri,  9 Jul 2010 10:02:31 +0000 (UTC) (envelope-from tobez@tobez.org)
Received: from heechee.tobez.org (heechee.tobez.org [194.255.56.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 49A208FC0A;
	Fri,  9 Jul 2010 10:02:31 +0000 (UTC)
Received: by heechee.tobez.org (Postfix, from userid 1001)
	id 68B126D400; Fri,  9 Jul 2010 12:02:30 +0200 (CEST)
Date: Fri, 9 Jul 2010 12:02:30 +0200
From: Anton Berezin <tobez@tobez.org>
To: Denis Shaposhnikov <dsh@vlink.ru>
Message-ID: <20100709100230.GA99812@heechee.tobez.org>
Mail-Followup-To: Anton Berezin <tobez@tobez.org>,
	Denis Shaposhnikov <dsh@vlink.ru>, ports-committers@FreeBSD.org,
	cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org,
	Yen-Ming Lee <leeym@FreeBSD.org>
References: <201006180034.o5I0YVRR012560@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201006180034.o5I0YVRR012560@repoman.freebsd.org>
X-Powered-By: FreeBSD http://www.freebsd.org/
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: cvs-ports@FreeBSD.org, Yen-Ming Lee <leeym@FreeBSD.org>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/devel/p5-Params-Validate Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jul 2010 10:02:31 -0000

Hi Denis,

I don't understand why you approved this PR.  Three days before
this commit I had a conversation with you with regard to this port missing a
dependency on ExtUtils::CBuilder.  You provided a diff with a fix,
which I immediately committed with minor modifications.

Then, three days later, you approve a PR which removes CBuilder dependency
which has just got it.

So now the port does not work again.  :-/

Could we somehow avoid such flip-flops in the future?  Maybe better testing
is in order?  Just a thought.

Cheers,
\Anton.

===>  Configuring for p5-Params-Validate-0.95_2
Warning: ExtUtils::CBuilder not installed or no compiler detected
Proceeding with configuration, but compilation may fail during Build

Checking prerequisites...
  build_requires:
    !  ExtUtils::CBuilder is not installed

ERRORS/WARNINGS FOUND IN PREREQUISITES.  You may wish to install the
versions
of the modules indicated above before proceeding with this installation

Run 'Build installdeps' to install missing prerequisites.

Creating new 'MYMETA.yml' with configuration results
Creating new 'Build' script for 'Params-Validate' version '0.95'
===>  Building for p5-Params-Validate-0.95_2
Building Params-Validate
Error: no compiler detected to compile 'lib/Params/Validate.c'.  Aborting
*** Error code 2


On Fri, Jun 18, 2010 at 12:34:31AM +0000, Yen-Ming Lee wrote:
> leeym       2010-06-18 00:34:31 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     devel/p5-Params-Validate Makefile 
>   Log:
>   - simplify dependency
>   - bump PORTREVISION
>   
>   PR:             ports/147954
>   Submitted by:   leeym
>   Approved by:    maintainer
>   
>   Revision  Changes    Path
>   1.42      +9 -6      ports/devel/p5-Params-Validate/Makefile
> 
> 
> 
>   cvsweb links:
>   http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/devel/p5-Params-Validate/Makefile

-- 
Our society can survive even a large amount of irrational regulation.
  -- John McCarthy