From owner-freebsd-current@freebsd.org Sat Aug 31 03:20:35 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7E5B0E20BE for ; Sat, 31 Aug 2019 03:20:35 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46L1nZ2gvrz3QVr; Sat, 31 Aug 2019 03:20:33 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 5709046D; Fri, 30 Aug 2019 23:20:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 30 Aug 2019 23:20:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=/ Gat1B6V/cuJNcIGWeQCqGvxr0Ff97HgODrgqww82/0=; b=V7ia6KTdJU1x78jIm uyZ+ZWaMF83DCwC4VQR/TAU/0s3nj96EF4PxhQgetCVjtroqvKPIS9ZUorwpBX2R Wpv/iL99YPgBiKPbNueX5bQnG8Hj8KBJ9TqeJAedlO98SVE6uVFeRBxnTcTGmLKm HaSo31d0YPXdi8bnaaD2jtF3NMoUl+AEdretktW+N2NA7EnoswewBif0g/6zk4Xr kmhrZSc4waUf5d4otB84fKanofTiSlwB0elWnuAXiSCSxrcpwBQnIVXcm3Ueb8Hl 0PP362mSUUflXX5ECSpgrWHiamqXEcSKeGcxmADRGiVPJjcdi6MQ4w4CrEJmLwqt 9zUUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=/Gat1B6V/cuJNcIGWeQCqGvxr0Ff97HgODrgqww82 /0=; b=iLguzMOw2yJzfceRU6gcnfUiP9lwcfBMnrt9+rNxLndaC9uGoXZgZZ/6C oOr7GLKoAM66cgqomjM/WJXRqidkjrTKIgPrnjB0KGWffaYeTMnAssnd1bp0oVNX hD/65TnBkcOVh21qhg8x8OcycYW5+arHys7JyNs53jJ1IIplOQYoKoVMjOij3Q1R Ww9NGCkalO3Zl7v3Fukf+XZ7gdIBldaCOFu0RSiA62fG85VEtGC4dWAvJlmX3IvU 8H7R7XtphRobbNG6oqJ7rMp3BkK20wpEw2mygMhJIldusFDKN/b8ocEXnEDzmMnO 3FKr5iBYbxrH6OAxecvwmdi89d7bw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudeihedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefheenucfhrhhomhepjghurhhi ucfrrghnkhhovhcuoeihuhhrihhpvheshihurhhiphhvrdhnvghtqeenucffohhmrghinh eplhgvrhgtthhrrdhorhhgnecukfhppeduleehrddvtdeirddukeefrdduieejnecurfgr rhgrmhepmhgrihhlfhhrohhmpeihuhhrihhpvheshihurhhiphhvrdhnvghtnecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from [192.168.1.2] (unknown [195.206.183.167]) by mail.messagingengine.com (Postfix) with ESMTPA id 83CA480059; Fri, 30 Aug 2019 23:20:29 -0400 (EDT) Subject: Re: sysutils/lsof: VOP_FSYNC definition moved? To: Larry Rosenman , Freebsd current References: From: Yuri Pankov Message-ID: <0aceb3c6-2f73-7b97-b3a9-d2598cd79d6c@yuripv.net> Date: Sat, 31 Aug 2019 06:20:27 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46L1nZ2gvrz3QVr X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yuripv.net header.s=fm1 header.b=V7ia6KTd; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=iLguzMOw; dmarc=none; spf=pass (mx1.freebsd.org: domain of yuripv@yuripv.net designates 64.147.123.18 as permitted sender) smtp.mailfrom=yuripv@yuripv.net X-Spamd-Result: default: False [-1.04 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(0.00)[yuripv.net:s=fm1,messagingengine.com:s=fm3]; RSPAMD_URIBL(4.50)[lerctr.org]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:64.147.123.18]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[yuripv.net]; BAD_REP_POLICIES(0.10)[]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; RCVD_COUNT_THREE(0.00)[4]; IP_SCORE(-3.50)[ip: (-9.87), ipnet: 64.147.123.0/24(-4.89), asn: 11403(-2.68), country: US(-0.05)]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yuripv.net:+,messagingengine.com:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.96)[-0.965,0]; NEURAL_HAM_MEDIUM(-0.98)[-0.979,0]; RCVD_IN_DNSWL_LOW(-0.10)[18.123.147.64.list.dnswl.org : 127.0.5.1]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:11403, ipnet:64.147.123.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Aug 2019 03:20:35 -0000 Larry Rosenman wrote: > http://home.lerctr.org:8888/data/live-host-ports/2019-08-30_20h25m06s/logs/errors/lsof-4.93.2_4,8.log > > --- dnode2.o --- > In file included from dnode2.c:56: > In file included from > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_znode.h:33: > In file included from > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu.h:47: > In file included from > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_context.h:73: > In file included from /usr/src/sys/cddl/compat/opensolaris/sys/vfs.h:37: > /usr/src/sys/cddl/compat/opensolaris/sys/vnode.h:243:10: warning: > implicit declaration of function 'VOP_FSYNC' is invalid in C99 > [-Wimplicit-function-declaration] > error = VOP_FSYNC(vp, MNT_WAIT, curthread); > ^ > 1 warning generated. > A failure has been detected in another branch of the parallel make Real error seems to be way above that (see below), and VOP_FSYNC one is just a fallout from that. It is likely related to r351594 by Konstantin, but I didn't look into the details. You could try defining _SYS_PCPU_H_ before including in dlsof.h with _KERNEL defined -- this seems to fix the lsof build for me. ------------- In file included from ckkv.c:43: In file included from ./../lsof.h:221: In file included from ./../dlsof.h:412: In file included from /usr/src/sys/sys/file.h:44: In file included from /usr/src/sys/sys/refcount.h:36: In file included from /usr/src/sys/sys/systm.h:126: In file included from /usr/src/sys/sys/pcpu.h:223: /usr/include/machine/pcpu_aux.h:55:55: error: expected expression __asm("movq %%gs:%P1,%0" : "=r" (td) : "n" (offsetof(struct pcpu, ^ /usr/include/machine/pcpu_aux.h:56:6: error: use of undeclared identifier 'pc_curthread'; did you mean '__curthread'? pc_curthread))); ^ /usr/include/machine/pcpu_aux.h:51:1: note: '__curthread' declared here __curthread(void) ^ /usr/include/machine/pcpu_aux.h:66:56: error: expected expression __asm("movq %%gs:%P1,%0" : "=r" (pcb) : "n" (offsetof(struct pcpu, ^ /usr/include/machine/pcpu_aux.h:67:6: error: use of undeclared identifier 'pc_curpcb'; did you mean '__curpcb'? pc_curpcb))); ^ /usr/include/machine/pcpu_aux.h:62:1: note: '__curpcb' declared here __curpcb(void)