From owner-freebsd-current@FreeBSD.ORG  Tue Jul  6 11:25:55 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C744B16A4CE
	for <current@freebsd.org>; Tue,  6 Jul 2004 11:25:55 +0000 (GMT)
Received: from smtp.des.no (flood.des.no [217.116.83.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D8B6F43D41
	for <current@freebsd.org>; Tue,  6 Jul 2004 11:25:54 +0000 (GMT)
	(envelope-from des@des.no)
Received: by smtp.des.no (Pony Express, from userid 666)
	id 7918B530C; Tue,  6 Jul 2004 13:25:53 +0200 (CEST)
Received: from dwp.des.no (des.no [80.203.228.37])
	by smtp.des.no (Pony Express) with ESMTP
	id F1C325309; Tue,  6 Jul 2004 13:25:45 +0200 (CEST)
Received: by dwp.des.no (Postfix, from userid 2602)
	id 96625B860; Tue,  6 Jul 2004 13:25:45 +0200 (CEST)
To: David Malone <dwmalone@maths.tcd.ie>
References: <20040705133820.GA9159@stud.fit.vutbr.cz>
	<xzp1xjqbhee.fsf@dwp.des.no>
	<20040705161059.GA52584@walton.maths.tcd.ie>
	<xzpsmc6a02c.fsf@dwp.des.no> <xzpoemu9zfe.fsf@dwp.des.no>
	<20040706082906.GA50212@stud.fit.vutbr.cz>
	<xzpeknpbg0t.fsf@dwp.des.no>
	<20040706111403.GA68327@walton.maths.tcd.ie>
From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=)
Date: Tue, 06 Jul 2004 13:25:45 +0200
In-Reply-To: <20040706111403.GA68327@walton.maths.tcd.ie> (David Malone's
 message of "Tue, 6 Jul 2004 12:14:03 +0100")
Message-ID: <xzpvfh19y2u.fsf@dwp.des.no>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on flood.des.no
X-Spam-Level: 
X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63
cc: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
cc: current@freebsd.org
Subject: Re: recent libalias changes
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jul 2004 11:25:55 -0000

David Malone <dwmalone@maths.tcd.ie> writes:
> The bit of the function that the patch changes seems to only be
> accessing the data through char types, which the C standard says
> can alias any type.

the code I replaced has casts on the lvalue, which is not allowed.

>                     The while loop that is immediately above it
> looks risky though, as this function is probably called with a
> struct ip * somewhere.

yes, that's what I think may need rewriting.

DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no