Date: Tue, 12 Jan 1999 12:45:09 +0100 (MET) From: Luigi Rizzo <luigi@labinfo.iet.unipi.it> To: eivind@FreeBSD.ORG (Eivind Eklund) Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_input.c Message-ID: <199901121145.MAA23908@labinfo.iet.unipi.it> In-Reply-To: <19990112143551.D65459@bitbox.follo.net> from "Eivind Eklund" at Jan 12, 99 02:35:32 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > > Add #ifdef's to avoid unused label warning in some cases. > > > > i wonder if it is preferable to clutter the code with #ifdef's or > > tolerate the potential warnings. > > Unless good counter-arguments spring forward, -Werror is going in > shortly, so tolerating the warnings is not an option. in this specific case (haven't seen the patch yet but i suspect is one of the labels in the iphack section) it's because there is a ton of #ifdef's there and the code is already hard to follow. Of course the -Werror thing removes any value to this objection. Is there a compiler thing such as /*NOTREACHED*/ to prevent warnings for unused labels ? luigi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901121145.MAA23908>