Date: Thu, 27 Mar 2008 07:52:42 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: John Birrell <jb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/include param.h src/sys/arm/include param.h src/sys/i386/include param.h src/sys/ia64/include param.h src/sys/powerpc/include param.h src/sys/sparc64/include param.h src/sys/sun4v/include param.h Message-ID: <20080327072329.U34007@fledge.watson.org> In-Reply-To: <200803270503.m2R53Qr7053473@repoman.freebsd.org> References: <200803270503.m2R53Qr7053473@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 27 Mar 2008, John Birrell wrote: > jb 2008-03-27 05:03:26 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/include param.h > sys/arm/include param.h > sys/i386/include param.h > sys/ia64/include param.h > sys/powerpc/include param.h > sys/sparc64/include param.h > sys/sun4v/include param.h > Log: > When building a kernel module, define MAXCPU the same as SMP so > that modules work with and without SMP. Hmm. I think this probably is the right thing, but we'll need to be very careful to watch for people defining foo[MAXCPU] in globally visible data structures in the kernel in such a way that entries for the non-current CPU are referenced by any modules. A casual glance suggests that, right now, this is not generally an issue, but something to watch out for, since we do use MAXCPU to size a number of kernel data structures. Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080327072329.U34007>