Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 Apr 2011 02:10:18 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/x11-wm/openbox Makefile
Message-ID:  <20110401021018.GA39870@FreeBSD.org>
In-Reply-To: <4D953326.6060009@FreeBSD.org>
References:  <201103311745.p2VHjmjg016713@repoman.freebsd.org> <4D94D0AB.1030304@FreeBSD.org> <20110401012058.GA35816@FreeBSD.org> <4D953326.6060009@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 31, 2011 at 07:06:30PM -0700, Doug Barton wrote:
> On 03/31/2011 18:20, Alexey Dokuchaev wrote:
> >On Thu, Mar 31, 2011 at 12:06:19PM -0700, Doug Barton wrote:
> >>You also removed the post-patch target, was this intentional?
> >
> >Yes, sorry; this change was suggested by novel@ but I forgot to include
> >it in the commit log (which was composed earlier by me).  Because of
> >problems with my MX I did not promptly receive his approval, and after a
> >while simply forgot to update commit message.
> 
> No problem, thanks (both) for clarifying. :)  In case it's not clear, I 
> have no objection to the change, just wanted to be sure it was intentional.

I understand; but I am also quite picky on the preciseness of commit logs
and especially when I forget something substantial like removed target.

Thanks for keeping an eye, much appreciated.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110401021018.GA39870>