From owner-freebsd-geom@FreeBSD.ORG  Thu Aug 10 20:00:15 2006
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
X-Original-To: freebsd-geom@FreeBSD.org
Delivered-To: freebsd-geom@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8E98516A4DF
	for <freebsd-geom@FreeBSD.org>; Thu, 10 Aug 2006 20:00:15 +0000 (UTC)
	(envelope-from arne_woerner@yahoo.com)
Received: from web30306.mail.mud.yahoo.com (web30306.mail.mud.yahoo.com
	[209.191.69.68]) by mx1.FreeBSD.org (Postfix) with SMTP id 4EBE243D53
	for <freebsd-geom@FreeBSD.org>; Thu, 10 Aug 2006 20:00:10 +0000 (GMT)
	(envelope-from arne_woerner@yahoo.com)
Received: (qmail 98204 invoked by uid 60001); 10 Aug 2006 20:00:09 -0000
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com;
	h=Message-ID:Received:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
	b=SwQQzOP9LFfE7G4hbjAVzsnTa+1e7hjziy9QWYDQb+O2bPe5jMzGjaXx6vy/G1tjfhTaTunAwHwJ2cnV9tg0wl25KSiLg9UPckc82WJmou06oFYcYvjsHra8e88cOf43MSCISPrRRt3OwfIn/s+ssGGy6xgvAPz+7wcA61sxgaU=
	; 
Message-ID: <20060810200009.98202.qmail@web30306.mail.mud.yahoo.com>
Received: from [213.54.70.229] by web30306.mail.mud.yahoo.com via HTTP;
	Thu, 10 Aug 2006 13:00:09 PDT
Date: Thu, 10 Aug 2006 13:00:09 -0700 (PDT)
From: "R. B. Riddick" <arne_woerner@yahoo.com>
To: Craig Boston <craig@xfoil.gank.org>, Eric Anderson <anderson@centtech.com>
In-Reply-To: <20060810191908.GA32326@nowhere>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: freebsd-fs@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>,
	freebsd-geom@FreeBSD.org
Subject: Re: GJournal (hopefully) final patches.
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Aug 2006 20:00:15 -0000

--- Craig Boston <craig@xfoil.gank.org> wrote:
> sbin/geom/class/journal/geom_journal.c:
> 
>                 if (jsize == -1) {
>                         /*
>                          * No journal size specified. 1GB should be safe
>                          * default.
>                          */
>                         jsize = 1073741824ULL;
>                 }
>                 msize = g_get_mediasize(data);
>                 ssize = g_get_sectorsize(data);
>                 if (jsize + ssize >= msize) {
>                         gctl_error(req, "Provider too small for journalling.
> "
>                             "You can try smaller jsize (default is %jd).",
>                             jsize);
>                         return;
>
The gctl_error message shall be rewritten:
It should be:
  "You can try smaller journal size (%jd too large).",
since "default" implies for me 1GB, while it might well be, that somebody chose
10GB.

-Arne

---
2*2=5

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com