From owner-freebsd-stable@FreeBSD.ORG Fri Nov 2 18:17:39 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ABCCD725 for ; Fri, 2 Nov 2012 18:17:39 +0000 (UTC) (envelope-from b.smeelen@ose.nl) Received: from mail.ose.nl (mail.ose.nl [212.178.134.164]) by mx1.freebsd.org (Postfix) with ESMTP id 08B838FC14 for ; Fri, 2 Nov 2012 18:17:38 +0000 (UTC) X-Footer: b3NlLm5s Received: from localhost ([127.0.0.1]) by mail.ose.nl (using TLSv1/SSLv3 with cipher AES256-SHA (256 bits)) for freebsd-stable@freebsd.org; Fri, 2 Nov 2012 19:17:37 +0100 Message-ID: <50940E40.3090709@ose.nl> Date: Fri, 02 Nov 2012 19:17:36 +0100 From: Bas Smeelen User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: freebsd-stable@freebsd.org Subject: Re: [patch proposal typo corrected] Re: SU+J on 9.1-RC2 ISO References: <5093F934.7050306@ose.nl> <5093FD3D.3080201@ateamsystems.com> <1351876381.2657.1.camel@mjakubik.localdomain> <50940276.5030306@ateamsystems.com> <50940C20.3090409@ose.nl> In-Reply-To: <50940C20.3090409@ose.nl> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2012 18:17:39 -0000 On 11/02/2012 07=3A08 PM=2C Bas Smeelen wrote=3A =3E On 11/02/2012 06=3A27 PM=2C Adam Strohl wrote=3A =3E=3E On 11/3/2012 0=3A13=2C Mike Jakubik wrote=3A =3E=3E=3E You can disable SU+J after installing=2C though it would be nice= if the =3E=3E=3E installer gave you a choice=2E =3E=3E This assumes that you know about this flaw=2C which most people do n= ot=2E =3E=3E =3E=3E I didn=27t until I discovered it by panic-ing a perfectly fine runni= ng =3E=3E server=2E Getting burned by a known bug like this shouldn=27t be=20= =22SOP=22 =3E=3E for users of FreeBSD=2E =3E=3E =3E=3E If anything it should be turned off by default=2C and people can tur= n it =3E=3E on if they want given the landmine it plants=2E If they know how to= =3E=3E turn it on they=27re much more likely to be aware of the issue=2E =3E=3E =3E=3E Sorry for the spam=2E Also since newer systems will be installing more and more on SSD it is=20= better to default SU+J to off as I understand from the original source=2E= Cheers =3E Hi all =3E =3E I am not sure if this is the right place=2C but would like to propose t= his =3E patch =3E root=40sys=3A/usr/src/usr=2Esbin/bsdinstall/partedit =23 diff -p gpart= =5Fops=2Ec =3E gpart=5Fops=2Ecnew =3E *** gpart=5Fops=2Ec Mon Aug 6 01=3A54=3A33 2012 =3E --- gpart=5Fops=2Ecnew Fri Nov 2 19=3A02=3A43 2012 =3E *************** newfs=5Fcommand=28const char *fstype=2C char * =3E *** 90=2C97 **** =3E =7B=22SU=22=2C =22Softupdates=22=2C =3E =22Enable softupdates =28default=29=22=2C 1 =7D=2C= =3E =7B=22SUJ=22=2C =22Softupdates journaling=22=2C =3E ! =22Enable file system journaling =28default - =22 =3E ! =22turn off for SSDs=29=22=2C 1 =7D=2C =3E =7B=22TRIM=22=2C =22Enable SSD TRIM support=22=2C =3E =22Enable TRIM support=2C useful on solid-state dri= ves=22=2C =3E 0 =7D=2C =3E --- 90=2C97 ---- =3E =7B=22SU=22=2C =22Softupdates=22=2C =3E =22Enable softupdates =28default=29=22=2C 1 =7D=2C= =3E =7B=22SUJ=22=2C =22Softupdates journaling=22=2C =3E ! =22Disable file system journaling =28default - =22 =3E ! =22turn on for adventurish admins=29=22=2C 0 =7D=2C= =3E =7B=22TRIM=22=2C =22Enable SSD TRIM support=22=2C =3E =22Enable TRIM support=2C useful on solid-state dri= ves=22=2C =3E 0 =7D=2C =3E =3E If OK I will file a PR =3E Cheers =3E Bas =3E =3E =3E =3E This e-mail message=2C including any attachment=28s=29=2C is intended s= olely for the addressee or addressees=2E Any views or opinions presented he= rein are solely those of the author and do not necessarily represent those= of OSE=2E =3E =3E If you are not the intended recipient of this communication please retu= rn this e-mail message and the attachment=28s=29 to the sender and delete a= nd destroy all copies=2E =3E =3E =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F =3E freebsd-stable=40freebsd=2Eorg mailing list =3E http=3A//lists=2Efreebsd=2Eorg/mailman/listinfo/freebsd-stable =3E To unsubscribe=2C send any mail to =22freebsd-stable-unsubscribe=40free= bsd=2Eorg=22 This e-mail message=2C including any attachment=28s=29=2C is intended solel= y for the addressee or addressees=2E Any views or opinions presented herein= are solely those of the author and do not necessarily represent those of O= SE=2E If you are not the intended recipient of this communication please return t= his e-mail message and the attachment=28s=29 to the sender and delete and d= estroy all copies=2E