From owner-freebsd-hackers Sun Feb 10 19: 7:12 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from squall.waterspout.com (squall.waterspout.com [208.13.56.12]) by hub.freebsd.org (Postfix) with ESMTP id E06EF37B400; Sun, 10 Feb 2002 19:07:05 -0800 (PST) Received: by squall.waterspout.com (Postfix, from userid 1050) id D50EB9B19; Sun, 10 Feb 2002 22:06:20 -0500 (EST) Date: Sun, 10 Feb 2002 22:06:20 -0500 From: Will Andrews To: nsayer@FreeBSD.org, funa@funa.org, j@gu.ru Cc: hackers@FreeBSD.org, mobile@FreeBSD.org Subject: RFR: spic(4)/moused(8) -CURRENT and -STABLE patches Message-ID: <20020211030620.GR82640@squall.waterspout.com> Mail-Followup-To: nsayer@FreeBSD.org, funa@funa.org, j@gu.ru, hackers@FreeBSD.org, mobile@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.26i Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi all, As an idle src committer, I'm requesting additional peer review for the following patches: http://csociety.org/~will/jogdial-current-2.diff http://csociety.org/~will/jogdial-stable-2.diff These patches: 1) Modify the spic(4) driver to support additional Sony Vaio laptop models. 2) Add support to moused(8) for the spic(4) driver. 3) Do not break world or kernel/LINT builds. :-) 4) Work. :-) (1) was submitted by Akira Funahashi-san . (2) was submitted by Juriy Goloveshkin . I adjusted the path for sys/sys/mouse.h's diff for -stable to sys/i386/include/mouse.h. I also modified Funahashi-san's patch to refer to the versapad type in the static array of mouse names as per his suggestion. I think it's strange it wasn't added there before when versapad support was added to moused(8). As far as I can tell, both of the above patches work on their respective branches. I've already asked Nick Sayer , the original author of the spic(4) driver, about whether or not MFC'ing spic(4) would be OK with him, and he's concurred. I have not heard from him on whether the patches are OK, but I've reviewed them to the best of my ability. I am also looking for people to test the -STABLE patch on their Vaio laptops to see if anyone else sees problems. Simply download the -STABLE patch and apply it like so: # cd /usr/src # fetch http://csociety.org/~will/jogdial-stable-2.diff # patch < jogdial-stable-2.diff Then add the spic0 device as is from LINT, build, install, reboot. Sorry, no module version available yet. Once a final patch has been done for -CURRENT, I will commit it. A week later, if there are no problems, I will commit the -STABLE version. Thanks, -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message