From owner-freebsd-current@freebsd.org Sat Aug 31 03:23:19 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 85896E236A for ; Sat, 31 Aug 2019 03:23:19 +0000 (UTC) (envelope-from ler@FreeBSD.org) Received: from thebighonker.lerctr.org (ns-b.lerctr.org [IPv6:2001:470:1f0f:3ad::53:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46L1rl2z1Tz3Qt1 for ; Sat, 31 Aug 2019 03:23:18 +0000 (UTC) (envelope-from ler@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uk+wRXcTeyXE9nEH8jIQWe/igUS+TKD/i2dc1TYV0Eo=; b=FKH4LFUr0B5+ZYK+ABWMfGuGq0 nAicv0P380HtdhVx44fTT+HIJhRHRNWGaDj7BCyas6GcrHqwCLMF4ooPzWdkvF7oamL3GorUj41gY WowqBvdH41JUuxwzHye4oWb2bJEu5FhQ9bOaYGiOGdAWjOxUHo/09UCsmLFdz1d9z81gXEagZOqB1 a5rOIJyxK71DP/XpTItQ9zmM5FJgIhe0f9tz4dFajNyNrO6Xe6pC/RaltmZo2znZ8tLrb/zNOn4j0 mEqRbG9YuLSUD5Bv7+N5GBgH2twYFMmGXqrRZwSfYZ+6SYw1HSG/luUYX7gyXW6TRwslRx+MLu7ej WWN/yw7Q==; Received: from thebighonker.lerctr.org ([2001:470:1f0f:3ad:bb:dcff:fe50:d900]:11208 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.1 (FreeBSD)) (envelope-from ) id 1i3tyw-000IuA-2W; Fri, 30 Aug 2019 22:23:18 -0500 Received: from 2600:1700:210:b180:a93d:f380:e1b8:2ac4 by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Fri, 30 Aug 2019 22:23:17 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 30 Aug 2019 22:23:17 -0500 From: Larry Rosenman To: Yuri Pankov Cc: Freebsd current Subject: Re: sysutils/lsof: VOP_FSYNC definition moved? In-Reply-To: <0aceb3c6-2f73-7b97-b3a9-d2598cd79d6c@yuripv.net> References: <0aceb3c6-2f73-7b97-b3a9-d2598cd79d6c@yuripv.net> Message-ID: <8cd7ddfa63b899b01f39b5c7e9074c7b@FreeBSD.org> X-Sender: ler@FreeBSD.org User-Agent: Roundcube Webmail/1.3.9 X-Rspamd-Queue-Id: 46L1rl2z1Tz3Qt1 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Aug 2019 03:23:19 -0000 On 08/30/2019 10:20 pm, Yuri Pankov wrote: > Larry Rosenman wrote: >> http://home.lerctr.org:8888/data/live-host-ports/2019-08-30_20h25m06s/logs/errors/lsof-4.93.2_4,8.log >> >> --- dnode2.o --- >> In file included from dnode2.c:56: >> In file included from >> /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_znode.h:33: >> In file included from >> /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu.h:47: >> In file included from >> /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_context.h:73: >> In file included from >> /usr/src/sys/cddl/compat/opensolaris/sys/vfs.h:37: >> /usr/src/sys/cddl/compat/opensolaris/sys/vnode.h:243:10: warning: >> implicit declaration of function 'VOP_FSYNC' is invalid in C99 >> [-Wimplicit-function-declaration] >> error = VOP_FSYNC(vp, MNT_WAIT, curthread); >> ^ >> 1 warning generated. >> A failure has been detected in another branch of the parallel make > > Real error seems to be way above that (see below), and VOP_FSYNC one is > just a fallout from that. It is likely related to r351594 by > Konstantin, but I didn't look into the details. You could try defining > _SYS_PCPU_H_ before including in dlsof.h with _KERNEL > defined -- this seems to fix the lsof build for me. > > ------------- > In file included from ckkv.c:43: > In file included from ./../lsof.h:221: > In file included from ./../dlsof.h:412: > In file included from /usr/src/sys/sys/file.h:44: > In file included from /usr/src/sys/sys/refcount.h:36: > In file included from /usr/src/sys/sys/systm.h:126: > In file included from /usr/src/sys/sys/pcpu.h:223: > /usr/include/machine/pcpu_aux.h:55:55: error: expected expression > __asm("movq %%gs:%P1,%0" : "=r" (td) : "n" (offsetof(struct > pcpu, > ^ > /usr/include/machine/pcpu_aux.h:56:6: error: use of undeclared > identifier 'pc_curthread'; did you mean '__curthread'? > pc_curthread))); > ^ > /usr/include/machine/pcpu_aux.h:51:1: note: '__curthread' declared here > __curthread(void) > ^ > /usr/include/machine/pcpu_aux.h:66:56: error: expected expression > __asm("movq %%gs:%P1,%0" : "=r" (pcb) : "n" (offsetof(struct > pcpu, > ^ > /usr/include/machine/pcpu_aux.h:67:6: error: use of undeclared > identifier 'pc_curpcb'; did you mean '__curpcb'? > pc_curpcb))); > ^ > /usr/include/machine/pcpu_aux.h:62:1: note: '__curpcb' declared here > __curpcb(void) Thanks, Yuri. I'd *REALLY* like someone with real kernel knowledge to look at lsof and help modernize the #ifdef mess. -- Larry Rosenman http://people.freebsd.org/~ler Phone: +1 214-642-9640 E-Mail: ler@FreeBSD.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106