Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Jul 2022 22:37:56 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 265349] devel/py-jsonschema: include schemas in build, fix pip version
Message-ID:  <bug-265349-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265349

            Bug ID: 265349
           Summary: devel/py-jsonschema: include schemas in build, fix pip
                    version
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: bofh@freebsd.org
          Reporter: ports@skyforge.at
          Assignee: bofh@freebsd.org
             Flags: maintainer-feedback?(bofh@freebsd.org)

Created attachment 235396
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D235396&action=
=3Dedit
devel/py-jsonschema: include schemas in build, fix pip version

The recent update of devel/py-jsonschema in [1] has two issues that need
fixing:

* The removal of the Manifest.in patch causes bug #264452 [2] to emerge aga=
in,
as the package is lacking the necessary json files
* Since the setup.py patch wasn't updated, the resulting package reports the
wrong version in pip:

# pip freeze | grep jsonschema
jsonschema=3D=3D4.6.0


I've attached a patch to update setup.py to the proper version, include var=
ious
namespace packages for data and added a MANIFEST.in that reincludes the json
files. I've confirmed that the resulting package includes the same files as=
 an
installation directly via pip in a venv.

A minor note perhaps: I think the core issue here is that while the PEP 517
build with hatch works miraculously, the legacy setup.py it generates is
incomplete when it comes to package data files, but fixing this to get a
reliable setup.py out of it will probably require some upstream involvement
that's out of scope for this issue.

Cheers,
Sascha

[1]
https://cgit.freebsd.org/ports/commit/?id=3D792df617c379c17328f6554f25e5627=
cfe7973c5
[2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264452

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-265349-7788>