From owner-cvs-all  Mon Oct  1 14:29:38 2001
Delivered-To: cvs-all@freebsd.org
Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169])
	by hub.freebsd.org (Postfix) with ESMTP
	id 778A637B409; Mon,  1 Oct 2001 14:29:33 -0700 (PDT)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.6/8.11.1) id f91LTVi97816;
	Mon, 1 Oct 2001 14:29:31 -0700 (PDT)
	(envelope-from obrien)
Date: Mon, 1 Oct 2001 14:29:31 -0700
From: "David O'Brien" <obrien@FreeBSD.ORG>
To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/etc rc
Message-ID: <20011001142931.A97773@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.ORG
References: <200109250155.f8P1tMR19221@freefall.freebsd.org> <20010930160801.A30603@alaska.cert.siemens.de> <20010930150859.B85562@dragon.nuxi.com> <20011001092717.A57657@alaska.cert.siemens.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20011001092717.A57657@alaska.cert.siemens.de>; from udo.schweigert@siemens.com on Mon, Oct 01, 2001 at 09:27:17AM +0200
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, Oct 01, 2001 at 09:27:17AM +0200, Udo Schweigert wrote:
> -				slist="${slist}${script_name_sep}${script}"
> +				if [ "${script}" != "${dir}/*.sh" ]; then
> +				    slist="${slist}${script_name_sep}${script}"
> +				fi

I don't see what is wrong with simply testing below for -f or -l.

> -		elif [ -f "${script}" ]; then
> -			echo "Skipping ${script}, not executable"
> +		else
> +			echo -n " (skipping ${script##*/})"

This is wrong as it removes the _explanation_ of why it was skipped.
The _expilation_ is key to what I am trying to achieve.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message