From owner-cvs-src@FreeBSD.ORG Thu Oct 7 07:19:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E54B16A4CE; Thu, 7 Oct 2004 07:19:40 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5BAE243D62; Thu, 7 Oct 2004 07:19:39 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i977JOFb093340; Thu, 7 Oct 2004 10:19:24 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 49163-19; Thu, 7 Oct 2004 10:19:21 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i977JKbi093249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 7 Oct 2004 10:19:20 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i977JPox079473; Thu, 7 Oct 2004 10:19:25 +0300 (EEST) (envelope-from ru) Date: Thu, 7 Oct 2004 10:19:22 +0300 From: Ruslan Ermilov To: Brian Somers Message-ID: <20041007071921.GA79430@ip.net.ua> References: <200410051303.i95D38Nl047864@repoman.freebsd.org> <20041005170427.548e6e9d@dev.lan.Awfulhak.org> <20041005172056.GA4568@ip.net.ua> <20041005230204.5401f0be@dev.lan.Awfulhak.org> <20041006204541.GA91640@ip.net.ua> <20041007075245.282af23f@dev.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy" Content-Disposition: inline In-Reply-To: <20041007075245.282af23f@dev.lan.Awfulhak.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/etc Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2004 07:19:40 -0000 --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Brian, On Thu, Oct 07, 2004 at 07:52:45AM +0100, Brian Somers wrote: > On Wed, 6 Oct 2004 23:45:41 +0300, Ruslan Ermilov wrote: > > On Tue, Oct 05, 2004 at 11:02:04PM +0100, Brian Somers wrote: > > > On Tue, 5 Oct 2004 20:20:56 +0300, Ruslan Ermilov wr= ote: > > > > > Shouldn't this be: > > > > >=20 > > > > > ln -fhs ../var/named/etc/namedb ${DESTDIR}/etc/namedb > > > > >=20 > > > > No. > > >=20 > > > If I mount an alternate filesystem hierarchy somewhere, isn't it a bit > > > useless/dangerous for symlinks to point outside of it? > > >=20 > > Please explain in more detail, I don't get it. (There are several > > symlinks already exist in /etc, and most of them are absolute.) >=20 > Well, it looks like there's rmt -> /usr/sbin/rmt and termcap -> > /usr/share/misc/termcap. I'd vote for making these relative too ;*) >=20 > I don't think these are as important as it's pretty rare that a person > needs to change /etc/termcap these days, and even more rare that they > would want to change /etc/rmt. >=20 > People with removable disks might want to configure them on one system > and then attach them to another, and part of that configuration might > be to set up a nameserver. It would be an easy mistake to change > /mnt/etc/namedb/named.conf, ship the disk, then find out that you've > just broken the machine you configured from... >=20 There's a chicken and egg problem with relative symlinking that uses "..". While having it relative would "fix" an issue that you mention above, it will equally create a problem if one has /etc as a symlink to some other directory, not necessarily one-level deep from root. Let's don't go this road again and again. We've learned the hard way (with /usr/lib symlinks to /lib, please see bsd.lib.mk commit logs for details) that relative symlinking that uses ".." is generally a bad idea, and that it should only be used when we're confident that resolving ".." will give us a sane path. Out of 798 system symlinks on a 5.x box here, 602 use relative ".." symlinking, but they are all safe: /usr/share/locale/*/* (559 symlinks) /usr/share/man/en.ISO8859-1/man* /usr/share/nls/*/* /usr/share/openssl/man/en.ISO8859-1/man* I currently don't like the idea of making /etc symlinks relative using ".." very much. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --gBBFr7Ir9EOA20Yy Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBZO35qRfpzJluFF4RAgqhAJ9WBbrehs/KD4/W1wdZHSbuvLvpHQCcCf+B ALtPh+ezSeZMJOKl0e/qc4A= =S68F -----END PGP SIGNATURE----- --gBBFr7Ir9EOA20Yy--