From owner-freebsd-current@FreeBSD.ORG Thu Oct 18 04:38:11 2012 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 91146215; Thu, 18 Oct 2012 04:38:11 +0000 (UTC) (envelope-from yuri.pankov@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 99FF78FC0A; Thu, 18 Oct 2012 04:38:10 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id b5so6906749lbd.13 for ; Wed, 17 Oct 2012 21:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=uM/J385GrOBgcsZJ+Z/kRu9sW66fiRsZTLGHsQvT0y8=; b=kFDnwkACw65FGGyd3TvPNeH2pghByGwQY9/Z7VDIb2U1CI/GUnPFeJ2YGkDO/lja+M 5cfvptZw5Q0OIvk1/I6p5G06rk0tmaE3vFhLvovO9rTX/TuLmH8UTZR3qtjMr15xS3qT Ue4SjMl5Q7Kd6vAaiwkg4Q501GAu93OhXS4IWlPb2Mk8M8CGxzts520S0XskTl3pHgix 8z8laElNSq4K9rSQ0gpk0Jrc/fwLznDY6YtTr9nmBiQV00PSTJBLYT/7nAkwfyp7qd5b pjsmDqJ+v8YB1U3rA874Vw7kjz2bKDNqgbL9ObuRR7lht5KsX9N4L1rhmpZKpy8IXwEo ZDhw== Received: by 10.152.110.229 with SMTP id id5mr17420813lab.36.1350535088971; Wed, 17 Oct 2012 21:38:08 -0700 (PDT) Received: from ?IPv6:2001:470:28:4ba:bd0d:c674:d614:f7e2? (altair.xvoid.org. [2001:470:28:4ba:bd0d:c674:d614:f7e2]) by mx.google.com with ESMTPS id m6sm5443806lbh.10.2012.10.17.21.38.05 (version=SSLv3 cipher=OTHER); Wed, 17 Oct 2012 21:38:08 -0700 (PDT) Message-ID: <507F87AF.10600@gmail.com> Date: Thu, 18 Oct 2012 08:38:07 +0400 From: Yuri Pankov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Andriy Gapon Subject: Re: Regression with ZFS on recent current References: <507EE9C1.7060800@madpilot.net> <507F1D9E.3010803@FreeBSD.org> <507F26F7.8090302@FreeBSD.org> In-Reply-To: <507F26F7.8090302@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "current@FreeBSD.org" , Guido Falsi , Martin Matuska X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2012 04:38:11 -0000 On Thu, 18 Oct 2012 00:45:27 +0300, Andriy Gapon wrote: > on 18/10/2012 00:05 Andriy Gapon said the following: >> on 17/10/2012 20:24 Guido Falsi said the following: >>> Hi! >>> >>> While testing portshaker I found a regression in latest current. >>> >>> portshaker depends on ZFS(when enabling ZFS support) remounting >>> filesystems on the fly when changing the mountpoint property. This is >>> working as expected on 9.x while on 10-current is not working. Problem >>> has appeared sometime before October 3rd. >> >> Can you clarify what you mean but this date? >> That the problem didn't exist in head until recently? Can you name a date when >> the problem didn't exists in head then? > > Oh, hmm, not sure if it is a bug that we imported from upstream or a porting > mistake. Before r238391 do_prefix variable in zfs_prop_set (in > cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c) was always initialized. > Now it is either explicitly set to B_FALSE or left alone uninitialized. > > http://svnweb.freebsd.org/base/head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c?r1=237119&r2=238391&pathrev=238391 Not sure if it's helpful, but I can't reproduce the issue with pretty recent illumos-gate (at r13853): sirius:root:~# zfs create -o mountpoint=/test rpool/test sirius:root:~# touch /test/baz sirius:root:~# zfs set mountpoint=/foo rpool/test sirius:root:~# ls -ld /foo/ drwxr-xr-x 2 root root 3 Oct 18 08:36 /foo/ sirius:root:~# ls -l /foo/ total 1 -rw-r--r-- 1 root root 0 Oct 18 08:36 baz sirius:root:~# zfs list rpool/test NAME USED AVAIL REFER MOUNTPOINT rpool/test 31K 737G 31K /foo >>> Here is some sample output from a9.x machine and a 10-current one: >>> >>> root@micro:~ [0]# uname -a >>> FreeBSD micro.madpilot.net 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0 >>> r239180: Sat Aug 11 00:14:47 CEST 2012 >>> root@micro.madpilot.net:/usr/obj/usr/src/sys/MICRO amd64 >>> root@micro:~ [0]# zfs create tank/test >>> root@micro:~ [0]# touch /test/baz >>> root@micro:~ [0]# zfs set mountpoint=/foo tank/test >>> root@micro:~ [0]# ls -ld /foo >>> drwxr-xr-x 2 root wheel 3 Oct 17 19:18 /foo >>> root@micro:~ [0]# ls -l /foo/ >>> total 1 >>> -rw-r--r-- 1 root wheel 0 Oct 17 19:18 baz >>> root@micro:~ [0]# zfs list tank/test >>> NAME USED AVAIL REFER MOUNTPOINT >>> tank/test 144K 826G 144K /foo >>> >>> >>> root@marvin:~ [0]# uname -a >>> FreeBSD marvin.madpilot.net 10.0-CURRENT FreeBSD 10.0-CURRENT #7 >>> r241638: Wed Oct 17 14:33:18 CEST 2012 >>> root@marvin.madpilot.net:/usr/obj/usr/src/sys/MARVIN amd64 >>> root@marvin:~ [0]# zfs create tank/test >>> root@marvin:~ [0]# touch /test/baz >>> root@marvin:~ [0]# zfs set mountpoint=/foo tank/test >>> root@marvin:~ [0]# ls -ld /foo >>> ls: /foo: No such file or directory >>> root@marvin:~ [1]# ls -l /foo/ >>> ls: /foo/: No such file or directory >>> root@marvin:~ [1]# ls -ld /test >>> drwxr-xr-x 2 root wheel 3 Oct 17 19:19 /test >>> root@marvin:~ [0]# zfs list tank/test >>> NAME USED AVAIL REFER MOUNTPOINT >>> tank/test 31K 240G 31K /foo >>> >>> >>> Is this known? is the new behavior expected? >>> >>> Am I doing something stupid? >>> >>> Thanks in advance >>> >> >> > >