Date: Fri, 4 Jan 2002 15:49:54 +0100 From: Eivind Eklund <eivind@FreeBSD.org> To: Julian Elischer <julian@elischer.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/share/man/man3 queue.3 Message-ID: <20020104154954.A12125@FreeBSD.org> In-Reply-To: <Pine.BSF.4.21.0201030138380.22265-100000@InterJet.elischer.org>; from julian@elischer.org on Thu, Jan 03, 2002 at 01:43:02AM -0800 References: <200201030919.g039J8v63350@apollo.backplane.com> <Pine.BSF.4.21.0201030138380.22265-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 03, 2002 at 01:43:02AM -0800, Julian Elischer wrote: > On Thu, 3 Jan 2002, Matthew Dillon wrote: > > The issue here is to extend an abstraction up to the point where > > the compiler can easily optimize it. > > Bugger the compiler, I want readable code.. > :-) So do I. And for that reason I'm strongly opposed to your idea. Without your change, I can view the available queue types as green, pink, and yellow, and mostly ignore what the differences between green, pink and yellow queues are. With your change, I have to memorize that pink queues set p to NULL when they are through iterating. This makes the code LESS readable, overall. It makes it about as easy to read when you HAVE memorized that pink queues set p to NULL when they are through iterating - and have memorized it so well that it is as internalized as the basic syntax of the C language. Please fix your code instead of making the documentation say your way is acceptable. It makes the code less readable for a lot of people out here. Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020104154954.A12125>