From owner-cvs-src@FreeBSD.ORG Mon Feb 28 21:29:27 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B83A616A4CE; Mon, 28 Feb 2005 21:29:27 +0000 (GMT) Received: from smtp-vbr1.xs4all.nl (smtp-vbr1.xs4all.nl [194.109.24.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D8D6843D49; Mon, 28 Feb 2005 21:29:26 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr1.xs4all.nl (8.12.11/8.12.11) with ESMTP id j1SLTK5W049396; Mon, 28 Feb 2005 22:29:24 +0100 (CET) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.3/8.12.9) with ESMTP id j1SLTKru079149; Mon, 28 Feb 2005 22:29:20 +0100 (CET) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.3/8.13.1/Submit) id j1SLTK8x079148; Mon, 28 Feb 2005 22:29:20 +0100 (CET) (envelope-from wb) Date: Mon, 28 Feb 2005 22:29:20 +0100 From: Wilko Bulte To: Scott Long Message-ID: <20050228212920.GA79131@freebie.xs4all.nl> References: <200502280926.j1S9QD9g004406@repoman.freebsd.org> <200502281509.56754.jhb@FreeBSD.org> <20050228205024.GA60713@dragon.nuxi.com> <42238828.1020500@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42238828.1020500@samsco.org> X-OS: FreeBSD 4.11-STABLE User-Agent: Mutt/1.5.6i X-Virus-Scanned: by XS4ALL Virus Scanner cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: John Baldwin cc: obrien@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/alpha/osf1 osf1_misc.c src/sys/amd64/linux32 linux32_machdep.c src/sys/compat/freebsd32 freebsd32_misc.c src/sys/compat/linux linux_misc.c src/sys/compat/svr4 svr4_misc.c src/sys/fs/procfs procfs_status.c src/sys/kern init_main.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2005 21:29:27 -0000 On Mon, Feb 28, 2005 at 02:07:52PM -0700, Scott Long wrote.. > David O'Brien wrote: > >On Mon, Feb 28, 2005 at 03:09:56PM -0500, John Baldwin wrote: > > > >>On Monday 28 February 2005 04:26 am, David E. O'Brien wrote: > >> > >>>obrien 2005-02-28 09:26:13 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: (Branch: RELENG_5) > >>> sys/alpha/osf1 osf1_misc.c > >>> sys/amd64/linux32 linux32_machdep.c > >>> sys/compat/freebsd32 freebsd32_misc.c > >>> sys/compat/linux linux_misc.c > >>> sys/compat/svr4 svr4_misc.c > >>> sys/fs/procfs procfs_status.c > >>> sys/kern init_main.c kern_acct.c kern_clock.c > >>> kern_exit.c kern_proc.c kern_resource.c > >>> kern_synch.c kern_time.c subr_trap.c > >>> tty.c > >>> sys/sys proc.h resourcevar.h syscallsubr.h > >>> Log: > >>> MFC: Rework how we store process times in the kernel such that we > >>> always > >>> store the raw values including for child process statistics and only > >>>compute the system and user timevals on demand. > >>> (See the 2004-10-05 18:51:12 UTC jhb commit for full details.) > >> > >>NO!!! This breaks the ABI for all kernel modules. I would have already > >>MFC'd it first if not for that. You should have asked me before MFcing > >>this. :( > > > > > >There are tons of "MFC after:" commits that people never got around to > >MFC'ing. I'm doing those now, and this was one of them. I'm seriously > >concerned that we don't diverge 6-CURRENT/5-STABLE as we did in the > >4.x/3.x days. > > > >We've already discussed dealing this commit on IRC, so I'll end here. > > > > The "MFC After' messages are merely a convenience reminder. You should > not be interpreting them as compulsory. We had this discussion years > ago and it's no different now. > > Scott Sounds like adding a "Do Not MFC, will break ABI" is called for in some circumstances. -- Wilko Bulte wilko@FreeBSD.org