Date: Mon, 01 Jul 2002 21:44:30 +0000 From: Dima Dorfman <dima@trit.org> To: sheldonh@freebsd.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/share/sgml authors.ent doc/en_US.ISO8859-1/articles/contributors article.sgml Message-ID: <20020701214430.880793E1E@turbine.trit.org> In-Reply-To: <20020701154046.GN85531@starjuice.net>; from sheldonh@starjuice.net on "Mon, 1 Jul 2002 17:40:46 %2B0200"
next in thread | previous in thread | raw e-mail | index | archive | help
Sheldon Hearn <sheldonh@starjuice.net> wrote:
> On (2002/07/01 08:30), Johan Karlsson wrote:
>
> > Modified files:
> > en_US.ISO8859-1/share/sgml authors.ent
> > en_US.ISO8859-1/articles/contributors article.sgml
> > Log:
> > Move myself from additional contributors to developers section.
> > Add authors entry for myself.
> >
> > Reviewed by: sheldonh (mentor)
> > Approved by: sheldonh (mentor)
>
> I have explained to Johan that Reviewed is not required when Approved is
> given.
Isn't this backwards? "Reviewed by" implies "Approved by", but not
the other way around; a maintainer (or mentor) might "Approve" a patch
without necessarily looking at ("Reviewing") it, but someone that
"Reviewed" a patch always "Approves" it. The text you proposed for
the Committers' Guide has the same problem.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020701214430.880793E1E>