From owner-cvs-all@FreeBSD.ORG Wed Sep 8 07:13:40 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A83216A4CE; Wed, 8 Sep 2004 07:13:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C4DD43D31; Wed, 8 Sep 2004 07:13:40 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i887DdH2058790; Wed, 8 Sep 2004 07:13:40 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i887Dd54058789; Wed, 8 Sep 2004 07:13:39 GMT (envelope-from imp) Message-Id: <200409080713.i887Dd54058789@repoman.freebsd.org> From: Warner Losh Date: Wed, 8 Sep 2004 07:13:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb ugen.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2004 07:13:40 -0000 imp 2004-09-08 07:13:39 UTC FreeBSD src repository Modified files: sys/dev/usb ugen.c Log: Back out 1.88. The reference counts are there to block detach until the sleepers in read/write/ioctl have gotten out, not to prevent the open device from going away. Restore the old behavior so that we have a chance to wake up sleepers when the usb device goes away, so they can properly return EIO back to the caller when this happens. Otherwise, we have a guarnateed panic waiting to happen when a device detaches with an active read channel. This should be merged to 5 asap. Revision Changes Path 1.89 +11 -9 src/sys/dev/usb/ugen.c