From owner-freebsd-current@FreeBSD.ORG Wed Nov 23 23:26:49 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 275C51065692; Wed, 23 Nov 2011 23:26:49 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id BE1FC8FC1C; Wed, 23 Nov 2011 23:26:48 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap4EAKiAzU6DaFvO/2dsb2JhbABEhQGmd4FyAQEEASNWBRYYAgINGQJZBogYowCRTYEwiByBFgSIIIwokig X-IronPort-AV: E=Sophos;i="4.69,562,1315195200"; d="scan'208";a="146713046" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-jnhn-pri.mail.uoguelph.ca with ESMTP; 23 Nov 2011 18:26:47 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id CB230B3F71; Wed, 23 Nov 2011 18:26:47 -0500 (EST) Date: Wed, 23 Nov 2011 18:26:47 -0500 (EST) From: Rick Macklem To: Sean Bruno Message-ID: <1555980227.268467.1322090807813.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <1322072781.12047.4.camel@hitfishpass-lx.corp.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.91.201] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - FF3.0 (Win)/6.0.10_GA_2692) Cc: FreeBSD-Current , Dimitry Andric Subject: Re: NFS + SVN problem? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2011 23:26:49 -0000 Sean Bruno wrote: > On Wed, 2011-11-23 at 09:58 -0800, Rick Macklem wrote: > > I don't know if Dimitry tried this, but you could also try the > > "nolockd" option, so that byte range locking is done locally in > > the client and avoids the NLM. > > > > Good luck with it and please let us know how it goes, rick > > This seems to allow SVN 1.7 to do whatever nonsense it is trying to > do. > I've modified my fstab on the test host in the cluster to: > > dumpster:/vol/volshscratch /dumpster/scratch nfs > rw,soft,intr,bg,nolockd,nosuid 0 0 > Yep. Unless you have multiple clients locking the same file concurrently, doing locking locally within the client is the way to go. (Although I'm not fond of "soft", I think the default timeout is pretty conservative, so it would take a network partitioning or VERY SLOW server to trigger it.) (The NLM and associated NSM protocols are fundamentally flawed in their design, so no implementation can be expected to make them work "correctly". Having said that, I am not familiar enough with the FreeBSD implementation to try and fix specific scenarios. I do have a patch submitted by John Dees that fixes the case where a process with read access to a file attempts to read lock it. This case fails for the code in head, because the nlm always tests for write access. I do plan on getting this patch into head at some point.) Oh, and don't hesitate to try NFSv4. It should do the locking correctly without needing "nolockd" and the more testing it gets, the better.;-) rick > Removing soft,intr had no effect. This, I suspect will be problematic > for clusteradm@ if we start updating hosts in the cluster. > > Sean