Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Oct 2013 10:50:17 +0100
From:      Mark R V Murray <mark@grondar.org>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mark Murray <markm@FreeBSD.org>
Subject:   Re: svn commit: r256377 - in head: etc/defaults etc/rc.d share/examples/kld/random_adaptor share/man/man4 sys/boot/forth sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe ...
Message-ID:  <3B77143C-7D82-4E62-9974-BC2C6846893F@grondar.org>
In-Reply-To: <20131013074825.GO41229@kib.kiev.ua>
References:  <201310121257.r9CCvvjO006546@svn.freebsd.org> <20131013074825.GO41229@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_17F46C5F-3696-4698-A195-29B6F82D0ACD
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii


On 13 Oct 2013, at 08:48, Konstantin Belousov <kostikbel@gmail.com> wrote:

> On Sat, Oct 12, 2013 at 12:57:57PM +0000, Mark Murray wrote:
>> Author: markm
>> Date: Sat Oct 12 12:57:57 2013
>> New Revision: 256377
>> URL: http://svnweb.freebsd.org/changeset/base/256377
>> 
>> Log:
>>  Merge from project branch. Uninteresting commits are trimmed.
>> 
>>  Refactor of /dev/random device. Main points include:
> 
> The random.ko is broken.  On boot, I get
> link_elf_obj: symbol live_entropy_source_deregister undefined
> KLD file random.ko - could not finalize loading
> 
> There are several files from dev/random which are listed as
> 'optional random' in conf/files but are not added to the SRCS in
> modules/random/Makefile. I do not know the intent of splitting the
> dev/random into the module and non-optional part of the kernel, so
> cannot provide the patch.
> 
> Please fix.

Here's the fix:

Index: sys/modules/random/Makefile
===================================================================
--- sys/modules/random/Makefile	(revision 256427)
+++ sys/modules/random/Makefile	(working copy)
@@ -10,7 +10,8 @@
 SRCS+=	nehemiah.c
 SRCS+=	ivy.c
 .endif
-SRCS+=	randomdev_soft.c yarrow.c hash.c
+SRCS+=	randomdev_soft.c random_harvestq.c live_entropy_sources.c
+SRCS+=	yarrow.c hash.c rwfile.c
 SRCS+=	rijndael-alg-fst.c rijndael-api-fst.c sha2.c
 SRCS+=	bus_if.h device_if.h vnode_if.h opt_cpu.h opt_random.h



M
-- 
Mark R V Murray


--Apple-Mail=_17F46C5F-3696-4698-A195-29B6F82D0ACD
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.20 (Darwin)
Comment: GPGTools - http://gpgtools.org

iQCVAwUBUlps2d58vKOKE6LNAQqrxgP/Qcg3u09jSqOd1uUHh9gU3Yi8wU0aSjmY
nZ/6kuzvGRHvMg5mozZwp59dWe38GTorMp91Yh9TjPwdVFKY80W3naT6AMXmGY5Z
ojntyXYjPobgWVsIYLm3UC1n8XayjUjMjVITpgOMsvlpss9aw19iqAY2v72l52bQ
7nuMh2fdY+k=
=pdg8
-----END PGP SIGNATURE-----

--Apple-Mail=_17F46C5F-3696-4698-A195-29B6F82D0ACD--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B77143C-7D82-4E62-9974-BC2C6846893F>