From owner-freebsd-arm@FreeBSD.ORG Mon Jun 1 00:24:34 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 85378360 for ; Mon, 1 Jun 2015 00:24:34 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CB531246 for ; Mon, 1 Jun 2015 00:24:34 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t510OYoN027521 for ; Mon, 1 Jun 2015 00:24:34 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t510OYcd027520; Mon, 1 Jun 2015 00:24:34 GMT (envelope-from daemon-user) Date: Mon, 1 Jun 2015 00:24:34 +0000 To: freebsd-arm@freebsd.org From: "zbb (Zbigniew Bodek)" Subject: [Differential] [Commented On] D2378: Introduce ITS support for ARM64 Message-ID: <03db5254b6cfbb3bb95c57e27b7bcd81@localhost.localdomain> X-Priority: 3 Thread-Topic: D2378: Introduce ITS support for ARM64 X-Herald-Rules: <28>, <31>, <32>, <34>, <8> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZTc3NjU2YTNlNjQxNDIwYzYxMmJlZjFmYzJmIFVrpkI= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2015 00:24:34 -0000 zbb added a comment. In https://reviews.freebsd.org/D2378#49645, @emaste wrote: > @zbb, do you have an ETA for the rebase and new review? I rebased this commit but I need to check for style issues before updating diff here. (Nevertheless I have it in the pipeline) INLINE COMMENTS sys/arm64/arm64/gic_v3_its.c:209-215 In the ideal situation the caller (intr_machdep.c) should use the proper 'dev' structure of ITS instead of GIC. So this should be fixed in the upper layer and when done this WO can be simply removed. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D2378 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: zbb, imp, ian, andrew, emaste, brueffer, joel, wblock Cc: gnn, kib, emaste, andrew, imp, freebsd-arm