From owner-cvs-all Wed Jan 10 12:17:35 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id D8E0837B400; Wed, 10 Jan 2001 12:17:12 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id HAA15768; Thu, 11 Jan 2001 07:17:09 +1100 Date: Thu, 11 Jan 2001 07:18:01 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: John Baldwin Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jake Burkholder Subject: Re: cvs commit: src/sys/alpha/alpha interrupt.c machdep.c mp_mac In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 10 Jan 2001, John Baldwin wrote: > On 10-Jan-01 Bruce Evans wrote: > > On Tue, 9 Jan 2001, Jake Burkholder wrote: > >> Log: > >> Use PCPU_GET, PCPU_PTR and PCPU_SET to access all per-cpu variables > >> other then curproc. > > > > I wish I had objected earlier to your previous changes to prepare for > > this mistake. Machine-independent code shouldn't know that some > > There is nothign wrong with MI code knowing that it is running on a SMP-aware > kernel. SMP is something that shouldn't be grafted into the side of the > kernel, it is something it should be fully aware of. The locking requirements > are different for per-cpu variables than for global ones for example. (Most > per-cpu variables don't need locking since they aren't contended, as opposed to > shared variables.) The macros can be made more efficient for the common case > (in fact, Jake already has it done) but that is an optimization that can be > done later. For now let's focus on getting this working right and worry about > optimization later. It was already working right (except for a minor problem with modules that was fixed in my version). You are wasting time making it work wrong. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message