From owner-freebsd-bugs@FreeBSD.ORG Tue Aug 16 15:00:31 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4190116A41F for ; Tue, 16 Aug 2005 15:00:31 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA36A43D46 for ; Tue, 16 Aug 2005 15:00:29 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j7GF0T20045413 for ; Tue, 16 Aug 2005 15:00:29 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j7GF0Ta5045412; Tue, 16 Aug 2005 15:00:29 GMT (envelope-from gnats) Resent-Date: Tue, 16 Aug 2005 15:00:29 GMT Resent-Message-Id: <200508161500.j7GF0Ta5045412@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Divacky Roman Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52ADF16A41F for ; Tue, 16 Aug 2005 14:54:18 +0000 (GMT) (envelope-from xdivac02@stud.fit.vutbr.cz) Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.10.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4AEFE43D48 for ; Tue, 16 Aug 2005 14:54:16 +0000 (GMT) (envelope-from xdivac02@stud.fit.vutbr.cz) Received: from eva.fit.vutbr.cz (localhost [127.0.0.1]) by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz) (8.13.4/8.13.3) with ESMTP id j7GEsEAo015410 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Tue, 16 Aug 2005 16:54:14 +0200 (CEST) Received: (from xdivac02@localhost) by eva.fit.vutbr.cz (8.13.4/8.13.3/Submit) id j7GEsELq015409; Tue, 16 Aug 2005 16:54:14 +0200 (CEST) Message-Id: <200508161454.j7GEsELq015409@eva.fit.vutbr.cz> Date: Tue, 16 Aug 2005 16:54:14 +0200 (CEST) From: Divacky Roman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/84995: gcc4.x cleanup of usr.bin/window X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Divacky Roman List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2005 15:00:31 -0000 >Number: 84995 >Category: bin >Synopsis: gcc4.x cleanup of usr.bin/window >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue Aug 16 15:00:29 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Divacky Roman >Release: FreeBSD 7.0-CURRENT i386 >Organization: home >Environment: FreeBSD witten 7.0-CURRENT FreeBSD 7.0-CURRENT #55: Tue Aug 16 12:59:09 CEST 2005 root@witten:/usr/obj/usr/src/sys/NEOLOGISM i386 >Description: gcc4.x (tested with gcc41) cleanup of usr.bin/window >How-To-Repeat: apply the patch >Fix: Index: wwgets.c =================================================================== RCS file: /home/ncvs/src/usr.bin/window/wwgets.c,v retrieving revision 1.5 diff -u -r1.5 wwgets.c --- wwgets.c 17 May 2001 09:38:49 -0000 1.5 +++ wwgets.c 11 Aug 2005 13:40:05 -0000 @@ -43,15 +43,21 @@ #include "ww.h" #include "char.h" -wwgets(buf, n, w) -char *buf; -int n; -register struct ww *w; +static void +rub(unsigned char c, struct ww *w) +{ + int i; + + for (i = isctrl(c) ? strlen(unctrl(c)) : 1; --i >= 0;) + (void) wwwrite(w, "\b \b", 3); +} + +void +wwgets(char *buf, int n, struct ww *w) { register char *p = buf; register int c; char uc = w->ww_unctrl; - static void rub(); w->ww_unctrl = 0; for (;;) { @@ -101,14 +107,4 @@ } *p = 0; w->ww_unctrl = uc; -} - -static void -rub(c, w) -struct ww *w; -{ - register i; - - for (i = isctrl(c) ? strlen(unctrl(c)) : 1; --i >= 0;) - (void) wwwrite(w, "\b \b", 3); } >Release-Note: >Audit-Trail: >Unformatted: