Date: Sat, 28 Dec 2013 02:27:11 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Michael Gmelin <freebsd@grem.de> Cc: marino@freebsd.org, Dimitry Andric <dim@FreeBSD.org>, FreeBSD Mailing List <freebsd-ports@freebsd.org> Subject: Re: bsd.port.mk FETCH_ARGS defaults, why "-A" ? Message-ID: <20131228012711.GJ40122@ithaqua.etoilebsd.net> In-Reply-To: <20131228020531.468e36f9@bsd64.grem.de> References: <52BE1763.8090105@marino.st> <FF64DFE1-6245-4370-8FD1-77300848CF88@FreeBSD.org> <52BE20DD.8060403@marino.st> <20131228005622.GH40122@ithaqua.etoilebsd.net> <20131228020531.468e36f9@bsd64.grem.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--mjUDp/cLGeqUhYyE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 28, 2013 at 02:05:31AM +0100, Michael Gmelin wrote: > On Sat, 28 Dec 2013 01:56:22 +0100 > Baptiste Daroussin <bapt@FreeBSD.org> wrote: >=20 > > On Sat, Dec 28, 2013 at 01:52:45AM +0100, John Marino wrote: > > > On 12/28/2013 01:49, Dimitry Andric wrote: > > > > On 28 Dec 2013, at 01:12, John Marino <freebsd.contact@marino.st> > > > > wrote: > > > >> For months I've been getting a lot of fetch failures in ports > > > >> that I couldn't reproduce outside of them. It appears it is > > > >> caused by the default "-A" passed to fetch. > > > >> > > > >> For example, /usr/ports/emulators/javatari will fail with "make > > > >> fetch" but it will succeed with with "make fetch FETCH_ARGS=3D-Fpr" > > > >> > > > >> I'd like to understand why "-A" is the default. Clearly many > > > >> distfiles could be retrieved that aren't, so I'd like to know > > > >> what -A is saving us from, and why that would be worse than the > > > >> current situation? > > > >=20 > > > > Crappy download sites that redirect you to ad pages, malware > > > > domains, or worse? > > > >=20 > > >=20 > > > And? > > > The checksum won't match, and the next site in the MASTER_SITES list > > > will be checked, right? What is the downside of this redirect? > > > Keep in mind that the site was once "approved" by the port > > > maintainer, it's not some random URL stuck in a wiki. > >=20 > > That's to avoid infinite loop on redirection > >=20 > > bapt >=20 > libfetch allows a maximum um five redirects and the -A flag is > implemented in terms of limiting this to one: >=20 > http.c: > ... > /* Maximum number of redirects to follow */ > #define MAX_REDIRECT 5 > ... > /* if the A flag is set, we only get one try */ > n =3D noredirect ? 1 : MAX_REDIRECT; > i =3D 0; > ... >=20 Great so that s not an argument anymore, it was the argument I was told 2 y= ears ago when I proposed to remove the -A regards, Bapt --mjUDp/cLGeqUhYyE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlK+KO8ACgkQ8kTtMUmk6EwfdACfSBxNAQnQHQNLSbDtPUSeSWMS aBwAn2rOrisoWrPUQSGJjkOCob2uy2x+ =/6QL -----END PGP SIGNATURE----- --mjUDp/cLGeqUhYyE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131228012711.GJ40122>