Date: Thu, 26 Feb 2009 08:54:47 -0800 From: Andrew Thompson <thompsa@FreeBSD.org> To: Hans Petter Selasky <hselasky@c2i.net> Cc: freebsd-current@freebsd.org Subject: Re: USB devfs patch Message-ID: <20090226165447.GA47932@citylink.fud.org.nz> In-Reply-To: <200902260948.31967.hselasky@c2i.net> References: <20090226020330.GC25211@citylink.fud.org.nz> <200902260948.31967.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 26, 2009 at 09:48:31AM +0100, Hans Petter Selasky wrote: > On Thursday 26 February 2009, Andrew Thompson wrote: > > http://people.freebsd.org/~thompsa/usb-cdevs.diff > > Hi, > > Here is a list of comments and bugs. > The comments follow the diff from top to bottom. Thanks Hans, I will go through them all. > 6) Some non-gcc compilers will complain unless you do 0-1 when the > destination variable is unsigned. > > - usb2_free_pipe_data(udev, iface_index, 0 - 1); > + usb2_free_pipe_data(udev, iface_index, -1); This one in particular, if the variable is unsigned then you shouldnt be passing a negative value. Either make signed or use ~0 for the max value. cheers, Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090226165447.GA47932>