Date: Tue, 28 Jan 2003 18:50:03 -0800 (PST) From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/47602: New port : audio/gtkpod A gtk2 gui to manage iPod Message-ID: <200301290250.h0T2o3Vj097608@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/47602; it has been noted by GNATS.
From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: David LE BRUN <david@dyn-ns.net>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47602: New port : audio/gtkpod A gtk2 gui to manage iPod
Date: Wed, 29 Jan 2003 03:41:07 +0100
--=.bdpX3pVeuFXm3T
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Lately David LE BRUN told:
> sed 's/^X//' >gtkpod/Makefile << 'END-of-gtkpod/Makefile'
[...]
> XMASTER_SITE_SUBDIR= ${PORTNAME}
^^^^^ use tab
[...]
> XLIB_DEPENDS= gtk-x11-2.0.0:${PORTSDIR}/x11-toolkits/gtk20 \
> X id3:${PORTSDIR}/audio/id3lib \
> X gnugetopt:${PORTSDIR}/devel/libgnugetopt
1. use shlib major version?
2. is gnugetopt really needed or can it be depended on conditionally
(5.0-RELEASE and -CURRENT got getopt(3))?
[...]
> XCONFIGURE_ENV+= CFLAGS="${CFLAGS}"
needed?
> XCONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include"
why don't you use ${CPPFLAGS} here (like above and below)?
> XCONFIGURE_ENV+= CXXFLAGS="${CXXFLAGS}"
needed?
> XCONFIGURE_ENV+= LDFLAGS="${LDFLAGS} -lgnugetopt"
conditionalize? (see above)
> Xpre-patch:
> X# install locale correctly (not in lib dir but in share dir)
> X @${REINPLACE_CMD} -E -e 's|DATADIRNAME=lib|DATADIRNAME=share|' \
> X ${WRKSRC}/configure
> X @${REINPLACE_CMD} -E -e 's|\(libdir\)/locale|\(datadir\)/locale|' \
> X ${WRKSRC}/po/Makefile.in.in
don't use -E if you don't need to and if it complicates stuff:
@${REINPLACE_CMD} -e 's|DATADIRNAME=lib|DATADIRNAME=share|' \
${WRKSRC}/configure
@${REINPLACE_CMD} -e 's|(libdir)/locale|(datadir)/locale|' \
${WRKSRC}/po/Makefile.in.in
> Xpost-install:
> X.if !defined(NOPORTDOCS)
> X ${MKDIR} ${PREFIX}/share/doc/gtkpod
> X ${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/doc/gtkpod
use ${DOCSDIR}?
[...]
> sed 's/^X//' >gtkpod/pkg-comment << 'END-of-gtkpod/pkg-comment'
> XGtkpod is a GTK2 GUI to manage your iPod
don't need to have ${PORTNAME} in the pkg-comment; see pkg_info output
cheers
simon
--
/"\ http://corecode.ath.cx/#donate
\ /
\ ASCII Ribbon Campaign
/ \ Against HTML Mail and News
--=.bdpX3pVeuFXm3T
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+Nz9Dr5S+dk6z85oRAtUMAJoDVpIehUK9rua5wI/S6wiPOFnp4gCfdezL
6jTrdgjeThtjLwGwSx2Twmw=
=qENZ
-----END PGP SIGNATURE-----
--=.bdpX3pVeuFXm3T--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301290250.h0T2o3Vj097608>